Respect the Client's configured connect_timeout value#1327
Merged
Conversation
Since connect_timeout have a different non-zero default value compared to the other timeouts we never picked up the value from the Client since it looked like the connect_timeout = 30 was always explicitly set by the caller. Co-authored-by: Claude Code <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1327 +/- ##
==========================================
+ Coverage 88.04% 88.08% +0.03%
==========================================
Files 30 30
Lines 11841 11847 +6
==========================================
+ Hits 10425 10435 +10
+ Misses 1416 1412 -4 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
quinnj
approved these changes
Jul 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since connect_timeout have a different non-zero default value compared
to the other timeouts we never picked up the value from the Client since
it looked like the connect_timeout = 30 was always explicitly set by the
caller.
Co-authored-by: Claude Code noreply@anthropic.com