Update to LibCURLBuilder v0.5.1 (FreeBSD support)#65
Merged
Conversation
Collaborator
Author
|
@ararslan when you get the chance could you try building this on FreeBSD and running the tests? |
Codecov Report
@@ Coverage Diff @@
## master #65 +/- ##
=======================================
Coverage 13.33% 13.33%
=======================================
Files 2 2
Lines 75 75
=======================================
Hits 10 10
Misses 65 65Continue to review full report at Codecov.
|
Collaborator
Author
|
Additionally if you could at Cirrus CI to the JuliaWeb org then we should be able to get FreeBSD CI here. |
omus
changed the title
FreeBSD has the same issue as macOS and Windows that necessitates using `@test_broken`, namely that the cross-compiled libraries don't know where CACerts would live.
The binaries are broken due to linking issues that are unrelated to this (or any) package.
omus
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should now support FreeBSD. Note I updated the minimum version of BinaryProvider as older versions choke on the keywords provided in
download_info.