Skip to content

87 frontend admin modify time flow#98

Merged
wkim10 merged 5 commits intomainfrom
87-frontend-admin-modify-time-flow
Apr 23, 2025
Merged

87 frontend admin modify time flow#98
wkim10 merged 5 commits intomainfrom
87-frontend-admin-modify-time-flow

Conversation

@ManuP6789
Copy link
Collaborator

Description

Added frontend for the admin modify time flow.

Issues

#87

Screenshots

image

Test

Only front end still need to add logic for backend and error checking

Possible Downsides

For the calendar, I used DatePicker from MUI. Should we allow the calendar to pop out or no, the figma does not show it but I am not sure.

I also made the time slots into a component, which I got from the event page on the volunteer page.
image. Let me know if you want me to refactor the event page to use that component, it should be pretty straight forward it only handles logic for selecting time.

I also noticed that the ticket for Group Sign Up flow, uses the calendar and time slots, should we make those into components and use them for both tickets? Or is it different for each one?

Additional Documentations

@ManuP6789 ManuP6789 requested a review from wkim10 April 17, 2025 14:47
@ManuP6789 ManuP6789 self-assigned this Apr 17, 2025
@ManuP6789 ManuP6789 linked an issue Apr 17, 2025 that may be closed by this pull request
@wkim10
Copy link
Collaborator

wkim10 commented Apr 17, 2025

Looks great Manuel! In response to your questions:

  • Yes we want calendar to pop out like you made it
  • Thanks for putting the time slots into a component, yeah if you have time if you could refactor the events page to also use that component that would be great
  • You're also right about the group sign up flow, they should use the same components. Ideally, it would've been best if we could've finished one of those flows first before starting the next one, but because we have limited time we had to assign the tickets for the same sprint. After the other groups are done with that flow, we can look to consolidate the two and make things into components!

Copy link
Collaborator

@wkim10 wkim10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Manuel looks great overall! Only thing left is to just refactor the events page with the time slot component like you mentioned, after that's done feel free to merge!

@wkim10 wkim10 merged commit e031865 into main Apr 23, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Frontend] Admin Modify Time Flow

2 participants