Skip to content

startYear, endYear, measuredAs, and groupBy now show up in URL by default#227

Merged
shaynesidman merged 3 commits intomainfrom
197-bug-parameterized-urls-should-always-capture-default-states
Apr 20, 2026
Merged

startYear, endYear, measuredAs, and groupBy now show up in URL by default#227
shaynesidman merged 3 commits intomainfrom
197-bug-parameterized-urls-should-always-capture-default-states

Conversation

@annewu109
Copy link
Copy Markdown
Collaborator

Issue

#197

Who worked on this sprint/bug?

Anne Wu

Features Implemented

startYear, endYear, measuredAs, and groupBy now show up in URL for the graph page by default

Existing files modified

/src/app/chart/page.tsx

Tag Dan and Shayne

@danglorioso @shaynesidman

@annewu109 annewu109 linked an issue Apr 19, 2026 that may be closed by this pull request
@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 19, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
mhd Ready Ready Preview, Comment Apr 20, 2026 0:47am

@shaynesidman
Copy link
Copy Markdown
Collaborator

  • navigating to charts page yields the url /charts --no default state
  • refreshing puts start and end year in the url, but not measured as or group by

Check this out again

@annewu109
Copy link
Copy Markdown
Collaborator Author

hopefully should work now

@shaynesidman shaynesidman merged commit 20b198a into main Apr 20, 2026
2 checks passed
@tika tika deleted the 197-bug-parameterized-urls-should-always-capture-default-states branch April 23, 2026 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: Parameterized URLs should always capture default states

2 participants