fix(refresh): skip _shim-* files in orphan check#8
Merged
Conversation
generate-shims.sh produces _shim-*.md files in agents/review/ as generated artifacts, not synced content. The orphan check in sync-reviewers.sh previously flagged every one of them as "not in any configured source" on every sync — pure noise that made it harder to spot real orphans (e.g., when removing a configured source and wanting to clean up the files it had been producing). Extends the existing _template-reviewer.md skip to a case glob that also matches _shim-*. Matches the convention that underscore- prefixed files in this directory are internal/generated, not synced content. Discovered while cleaning up duplicate orchestrator-as-reviewer sources in reviewer-sources.yaml — every reviewer sync produced ~20 lines of orphan warnings for the auto-regenerated shim files. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
generate-shims.shproduces_shim-*.mdfiles inagents/review/as generated artifacts, not synced content. The orphan check insync-reviewers.shflagged every one of them asOrphan: _shim-X.md (not in any configured source)on every sync — ~20 lines of pure noise that made it harder to spot real orphans (e.g., when removing a configured source and wanting to verify cleanup of the files it had been producing).Fix
Extends the existing
_template-reviewer.mdskip to acaseglob that also matches_shim-*.Convention: underscore-prefixed files in
agents/review/are internal/generated and excluded from orphan reporting. Matches how_template-reviewer.mdwas already treated.Discovery context
Found while cleaning up duplicate orchestrator-as-reviewer sources in
reviewer-sources.yaml. Every reviewer sync produced a wall of orphan warnings for the auto-regenerated shim files, drowning the legitimate cleanup signal.Test plan
bash sync-reviewers.sh <registry> <output-dir>against a directory containing only_shim-*.mdfiles — confirm no orphan warnings emit.mdfile from a now-removed source) — confirm the orphan warning still fires🤖 Generated with Claude Code