fix(portal): ignore prose in snip Seen-on values#101
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Some snip headers use prose to indicate that a snip doesn't apply to one OS, e.g.
Junos: (none in this JVD — Junos PEs use ...)orJunos: —. The parser was splitting the value on whitespace and turning every word into a device chip, producing nonsense likeinthisinthisnext to the real device tokens in the Snip Library UI.What
portal/scripts/generate-snips.mjs— when parsingSeen on:values, stop at the first(...)continuation note and skip tokens that don't start with an alphanumeric character.portal/src/data/snips.json— regenerated; device chips now show only real device names.Expected impact
Seen ondevice lists.Source-of-truth
snips.jsonis generated. Regenerated vianode portal/scripts/generate-snips.mjs; CI--checkwill validate freshness.Test
seenOn.junos/seenOn.evoarray.enterprise_wan/ewan_adv_core_edge/.../evpn-vpws-fxc.conf(the originally reported snip) — chips now show only the four real devices.