feat(contracts): treasury epoch limits, min shares, rebalance order, loss CB#670
Open
success-OG wants to merge 2 commits into
Open
feat(contracts): treasury epoch limits, min shares, rebalance order, loss CB#670success-OG wants to merge 2 commits into
success-OG wants to merge 2 commits into
Conversation
|
@success-OG Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #642
closes #644
closes #645
closes #646
Summary
Adds four on-chain safety controls to the YieldVault Soroban contract:
withdraw_treasuryenforces budget, rolls windows by ledger time, and emitstrswdcap/trswdep/trswdevents.set_min_share_supplyblocks withdrawals that would leave0 < total_shares < min(dust lockup prevention).rebalance_strategiessorts targets by strategy address, divests in reverse order, then invests in ascending order to avoid nondeterministic drift.eval_cb_losstrips on excessive drawdown, blocks sensitive ops viaCircuitBreakerTripped, with adminset_cb_loss_baseline/reset_cb_loss.Tasks closed
set_treasury_withdraw_epoch_cap,set_trs_wd_epoch_len,withdraw_treasury,TreasuryWithdrawEpochWindowset_min_share_supply, check indo_withdrawrebalance_strategies+sort_strategy_targetsset_cb_loss_thresh,set_cb_loss_baseline,eval_cb_loss,is_cb_loss_tripped,reset_cb_lossTest plan
cargo buildincontracts/vaultmin_share_supply; confirm partial withdraw that leaves dust reverts withMinShareSupplyViolatedrebalance_strategieswith two strategies; confirm execution order is address-sortedtotal_assets; confirmCircuitBreakerTrippedblocks deposit/withdraw