Fix module detection (for real this time)#23
Conversation
|
Awesome, thanks for this. I'll play around with it this weekend and report back. |
|
Is this good to go as far as you're concerned? Would be great to get this in the next release. |
|
Can we add some test to see if annotating loops works? I frequently have issues with code like this (forget the pointless code that doesn't do anything): module Mod
function foo(n)
x = zeros(n)
@inbounds for i 1:n
x = sin(x)
end
end
end # moduleWhen I don't have |
|
I'm 99% sure this works now, but adding that test would be awesome regardless (maybe you could do that, @sglyon?). |
|
Sorry I never got back on this, having just checked I confirm it looks like it resolves everything I mentioned in JunoLab/atom-julia-client#308, as well as @sglyon's code from above. I also haven't found any other new problems. JunoLab/atom-julia-client#198 however is still unresolved however, although that's more block detection as opposed to module detection I suppose. |
|
Yup, block detection happens on the Atom/JS side. Will take a quick look at that. |
by using Tokenize.jl.
Should actually work this time around...
@marius311 Since you reported the bugs related to this, would you mind trying out this branch?