feat(core): adding extra information and logging surrounding exceptions #44
Merged
JustinCanton merged 3 commits intodevelopfrom Aug 14, 2022
Merged
feat(core): adding extra information and logging surrounding exceptions #44JustinCanton merged 3 commits intodevelopfrom
JustinCanton merged 3 commits intodevelopfrom
Conversation
Adding extra information into the data including the http status code response, and the uri that failed. Updating exception handling to use an exception provider. Creating a base Exception class that prints out the exception data on ToString.
Owner
Author
|
This review just expands on the exception functionality. Now when an invalid response is returned, it return more data associated with the failure. |
JustinCanton
added a commit
that referenced
this pull request
Aug 20, 2022
* feat(core): adding extra information and logging surrounding exceptions (#44) * feat(core): adding extra information and logging surrounding exceptions Adding extra information into the data including the http status code response, and the uri that failed. Updating exception handling to use an exception provider. Creating a base Exception class that prints out the exception data on ToString. * refactor: fixing code warnings * test(core): adding tests for the exception provider * fix(mapbox-geocoding): fixing an issue where the query is not properly encoded, and fixing an issue where the query string building is using an outdated method (#46) * fix(mapbox-geocoding): fixing an issue where the query is not properly encoded * feat: updating how query strings are created to be more inline with standards * test(mapbox-geocoding): adding tests for encoding of query information * feat(mapbox-geocoding): changing the encoding method to UrlEncoder for consistency * docs: updating the README and CHANGELOG
JustinCanton
added a commit
that referenced
this pull request
Aug 20, 2022
* feat(core): adding extra information and logging surrounding exceptions (#44) * feat(core): adding extra information and logging surrounding exceptions Adding extra information into the data including the http status code response, and the uri that failed. Updating exception handling to use an exception provider. Creating a base Exception class that prints out the exception data on ToString. * refactor: fixing code warnings * test(core): adding tests for the exception provider * fix(mapbox-geocoding): fixing an issue where the query is not properly encoded, and fixing an issue where the query string building is using an outdated method (#46) * fix(mapbox-geocoding): fixing an issue where the query is not properly encoded * feat: updating how query strings are created to be more inline with standards * test(mapbox-geocoding): adding tests for encoding of query information * feat(mapbox-geocoding): changing the encoding method to UrlEncoder for consistency * docs: updating the README and CHANGELOG
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #42