Skip to content

fix(AbsAgentWebSettings): allow media playback without user gesture (#339) #1082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jim-daf wants to merge 1 commit into
base: androidx
Choose a base branch
from
Open

fix(AbsAgentWebSettings): allow media playback without user gesture (#339) #1082

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions agentweb-core/src/main/java/com/just/agentweb/AbsAgentWebSettings.java
100755 → 100644
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,10 @@ private void settings(WebView webView) {
mWebSettings.setSupportZoom(true);
mWebSettings.setBuiltInZoomControls(false);
mWebSettings.setSavePassword(false);
// Issue #339: HTMLMediaElement.play() throws "API can only be initiated by
// a user gesture" for embedded video players that auto-play. Allow
// programmatic playback so embedded players (e.g. share-page videos) work.
mWebSettings.setMediaPlaybackRequiresUserGesture(false);
Copy link

Copilot AI Apr 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WebSettings#setMediaPlaybackRequiresUserGesture was added in API 17, but this library’s minSdkVersion is 14 (agentweb-core/build.gradle:9). Calling it unconditionally here can crash on API 14–16 (NoSuchMethodError/verification failure). Guard the call with if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.JELLY_BEAN_MR1) (or use reflection) so pre-17 devices don’t break.

Suggested change
mWebSettings.setMediaPlaybackRequiresUserGesture(false);
if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.JELLY_BEAN_MR1) {
mWebSettings.setMediaPlaybackRequiresUserGesture(false);
}

Copilot uses AI. Check for mistakes.
if (AgentWebUtils.checkNetwork(webView.getContext().getApplicationContext())) {
//根据cache-control获取数据。
mWebSettings.setCacheMode(WebSettings.LOAD_DEFAULT);
Expand Down
Loading