Skip to content

Conversation

@isHarryh
Copy link
Contributor

Summary

This PR:

  • Fixes some spelling typo.
  • Removes the 404 links in the "Important Object Types" (they have been moved to legacy_patch).
  • Addes a "Configurations" section where user can have a full understanding of customization.
  • Moves "UnityPy Encryption" and "C-Typetree" related content to the "Configuration" section.

@K0lb3
Copy link
Owner

K0lb3 commented Apr 18, 2025

I will take a look at this PR tomorrow.
I had some important stuff to handle IRL, and afterwards some tasks that accumulated due to it.

From a glance the changes look fine, but as @3ncy already mentioned in his comments, some rephrasing change the meanings of the text, which has to be discussed.

@K0lb3
Copy link
Owner

K0lb3 commented Apr 24, 2025

Sorry for the late response, I kinda forgot about the PR, and well, then Easter came with lots of hiking.

@isHarryh
Copy link
Contributor Author

Sorry for the late response, I kinda forgot about the PR, and well, then Easter came with lots of hiking.

That's okay. Btw, congratulations to UnityPy for receiving 1k stars!

I have updated the commits according to the suggestions from you and @3ncy . You can view the diffs.

Copy link
Owner

@K0lb3 K0lb3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again, thanks a lot.
Just one thing that I only noticed now has to be changed.

@K0lb3 K0lb3 merged commit 9fc3667 into K0lb3:master May 2, 2025
6 checks passed
@K0lb3
Copy link
Owner

K0lb3 commented May 2, 2025

Thanks a lot again 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants