fix(devops): resolve build and type errors breaking e2e#7623
Merged
Conversation
- Fix TS2352: cast Object.fromEntries through unknown for CommitCategory - Fix TS7016: add @types/jsdom for missing type declarations - Fix Vite build: add node:-prefixed externals (node:fs, node:path, etc.) to rollupOptions so proto-to-zod.ts compiles for library output
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Files
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pulls.ts:289:Object.fromEntries()→CommitCategorycast failed because TS can't narrow{ [k: string]: string[] }to a specific interface. Fixed by casting throughunknown.yt.tsandsanitization.ts:jsdomv22 doesn't ship types. Added@types/jsdomto root devDependencies.proto-to-zod.ts: Code importsnode:fsandnode:path(withnode:prefix) but rollup externals only listed barefs/path. Added allnode:-prefixed variants to externals.Test plan
nx run devops:buildpassesnx run devops-e2e:e2epasses (20 tests, 3 files)nx run devops:lintpasses (0 errors)