Skip to content

fix(devops): resolve build and type errors breaking e2e#7623

Merged
h0lybyte merged 1 commit intodevfrom
trunk/devops-e2e-fix-1772751353
Mar 5, 2026
Merged

fix(devops): resolve build and type errors breaking e2e#7623
h0lybyte merged 1 commit intodevfrom
trunk/devops-e2e-fix-1772751353

Conversation

@h0lybyte
Copy link
Member

@h0lybyte h0lybyte commented Mar 5, 2026

Summary

  • TS2352 in pulls.ts:289: Object.fromEntries()CommitCategory cast failed because TS can't narrow { [k: string]: string[] } to a specific interface. Fixed by casting through unknown.
  • TS7016 in yt.ts and sanitization.ts: jsdom v22 doesn't ship types. Added @types/jsdom to root devDependencies.
  • Vite build failure in proto-to-zod.ts: Code imports node:fs and node:path (with node: prefix) but rollup externals only listed bare fs/path. Added all node:-prefixed variants to externals.

Test plan

  • nx run devops:build passes
  • nx run devops-e2e:e2e passes (20 tests, 3 files)
  • nx run devops:lint passes (0 errors)

- Fix TS2352: cast Object.fromEntries through unknown for CommitCategory
- Fix TS7016: add @types/jsdom for missing type declarations
- Fix Vite build: add node:-prefixed externals (node:fs, node:path, etc.)
  to rollupOptions so proto-to-zod.ts compiles for library output
@github-actions
Copy link
Contributor

github-actions bot commented Mar 5, 2026

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails
npm/@types/jsdom 28.0.0 🟢 6.6
Details
CheckScoreReason
Packaging⚠️ -1packaging workflow not detected
Code-Review🟢 9Found 27/30 approved changesets -- score normalized to 9
Maintained🟢 1030 commit(s) and 1 issue activity found in the last 90 days -- score normalized to 10
CII-Best-Practices⚠️ 0no effort to earn an OpenSSF best practices badge detected
Dangerous-Workflow🟢 10no dangerous workflow patterns detected
Security-Policy🟢 10security policy file detected
License🟢 9license file detected
Token-Permissions⚠️ 0detected GitHub workflow tokens with excessive permissions
Signed-Releases⚠️ -1no releases found
Branch-Protection⚠️ -1internal error: error during branchesHandler.setup: internal error: some github tokens can't read classic branch protection rules: https://github.com/ossf/scorecard-action/blob/main/docs/authentication/fine-grained-auth-token.md
SAST⚠️ 0SAST tool is not run on all commits -- score normalized to 0
Pinned-Dependencies🟢 8dependency not pinned by hash detected -- score normalized to 8
Binary-Artifacts🟢 10no binaries found in the repo
Fuzzing⚠️ 0project is not fuzzed
npm/@types/tough-cookie 4.0.5 🟢 6.6
Details
CheckScoreReason
Packaging⚠️ -1packaging workflow not detected
Code-Review🟢 9Found 27/30 approved changesets -- score normalized to 9
Maintained🟢 1030 commit(s) and 1 issue activity found in the last 90 days -- score normalized to 10
CII-Best-Practices⚠️ 0no effort to earn an OpenSSF best practices badge detected
Dangerous-Workflow🟢 10no dangerous workflow patterns detected
Security-Policy🟢 10security policy file detected
License🟢 9license file detected
Token-Permissions⚠️ 0detected GitHub workflow tokens with excessive permissions
Signed-Releases⚠️ -1no releases found
Branch-Protection⚠️ -1internal error: error during branchesHandler.setup: internal error: some github tokens can't read classic branch protection rules: https://github.com/ossf/scorecard-action/blob/main/docs/authentication/fine-grained-auth-token.md
SAST⚠️ 0SAST tool is not run on all commits -- score normalized to 0
Pinned-Dependencies🟢 8dependency not pinned by hash detected -- score normalized to 8
Binary-Artifacts🟢 10no binaries found in the repo
Fuzzing⚠️ 0project is not fuzzed
npm/undici-types 7.22.0 🟢 8.2
Details
CheckScoreReason
Code-Review🟢 9Found 22/23 approved changesets -- score normalized to 9
Maintained🟢 1030 commit(s) and 12 issue activity found in the last 90 days -- score normalized to 10
Dependency-Update-Tool🟢 10update tool detected
Security-Policy🟢 9security policy file detected
Dangerous-Workflow🟢 10no dangerous workflow patterns detected
Binary-Artifacts🟢 8binaries present in source code
Token-Permissions⚠️ 0detected GitHub workflow tokens with excessive permissions
Pinned-Dependencies🟢 4dependency not pinned by hash detected -- score normalized to 4
CII-Best-Practices⚠️ 0no effort to earn an OpenSSF best practices badge detected
Vulnerabilities🟢 100 existing vulnerabilities detected
Branch-Protection⚠️ -1internal error: error during branchesHandler.setup: internal error: some github tokens can't read classic branch protection rules: https://github.com/ossf/scorecard-action/blob/main/docs/authentication/fine-grained-auth-token.md
Fuzzing🟢 10project is fuzzed
SAST🟢 9SAST tool detected but not run on all commits
Packaging🟢 10packaging workflow detected
License🟢 10license file detected
Signed-Releases⚠️ -1no releases found
CI-Tests🟢 1030 out of 30 merged PRs checked by a CI test -- score normalized to 10
Contributors🟢 10project has 80 contributing companies or organizations

Scanned Files

  • pnpm-lock.yaml

@h0lybyte h0lybyte merged commit 1da7b88 into dev Mar 5, 2026
5 checks passed
@h0lybyte h0lybyte deleted the trunk/devops-e2e-fix-1772751353 branch March 5, 2026 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant