fix(astro-kbve): align OSRS override field names with schema#7728
Merged
fix(astro-kbve): align OSRS override field names with schema#7728
Conversation
Fix cooking field naming mismatches in override files so component rendering works correctly: - karambwan: cook_ticks → ticks - monkfish: stop_burn → stop_burn_level, stop_burn_gauntlets → stop_burn_level_gauntlets Also regenerates 3 item pages with updated Wiki API data (GE limits).
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
Add fields present in override data but missing from schemas: - FoodSchema: type (fish/pie/cake), combo_food (1-tick eat) - CookingSchema: quest_required (quest needed to cook) - PotionSchema: effect (summary string), effects[].description - ShopSourceSchema: requirements (quest/skill to access shop) - RecipeSchema: product, product_id, product_quantity (output item) Also adds isComboFood() type guard. Both IOSRSSchema.ts and generated.ts updated to stay in sync.
Material quantity and recipe product_quantity can be ranges like "3-6" or "100-250" in override data. Changed from z.number() to z.union([z.number(), z.string()]) in both schema files.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
OSRSCookingSchema_3144.mdx(Cooked Karambwan):cook_ticks→ticks_7946.mdx(Monkfish):stop_burn→stop_burn_level,stop_burn_gauntlets→stop_burn_level_gauntletsThis is batch 1 of a slow, incremental OSRS override cleanup. The existing 974 overrides have a mix of schema-aligned and legacy field names. We're fixing them a few at a time to avoid regressions.
Schema Audit Context
Field naming analysis of all 1383 overrides found:
Two main issues across the mixed/legacy files:
obtaining,material,effect) — harmless with.passthrough()but don't rendercook_ticksvsticks,stop_burnvsstop_burn_level) — prevents component renderingTest plan
OSRSCookingSchemadefinitionsgenerate-osrs-items.mjsruns successfully (4525 items, 974 overrides applied)OSRSItemPanelfor karambwan and monkfish pages🤖 Generated with Claude Code