fix(discordsh): deduplicate DroidProvider/OverlayShell + audit fixes#7903
Merged
fix(discordsh): deduplicate DroidProvider/OverlayShell + audit fixes#7903
Conversation
Closes #7712 item 1 — DroidProvider and OverlayShell were rendered in both Footer.astro and the unused Layout.astro. Consolidate into NavBar.astro (present on every page via Starlight Header override) so React initializes these providers exactly once. Also fixes the Footer copy missing i18nPath and dataPath config.
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
…nnect, Redirect component - Add loading="lazy" and decoding="async" to server card images - Replace onMouseEnter/onMouseLeave JS hover with CSS-only .server-card:hover - Add hCaptcha preconnect links to Starlight head config - Fix nanostore subscription leak in NavBar (unsub on astro:before-swap) - Create reusable Redirect.astro in @kbve/astro with meta refresh + JS fallback - Use Redirect component for auth/index page - Add @kbve/astro/components/* tsconfig path for .astro subpath imports Ref #7712
This was referenced Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DroidProviderandOverlayShellintoNavBar.astro— single mount point for all pages via the Starlight Header overrideFooter.astro(also fixes missingi18nPath/dataPathconfig on the Footer copy)Related
Closes #7712
Test plan