Conversation
…check-desktop, e2e, and dry targets for all bevy packages
…8115) The beforeBuildCommand runs build:wasm which uses RUSTUP_TOOLCHAIN=nightly with -Z build-std=panic_abort,std. Without nightly + rust-src installed, the WASM cargo build fails and wasm-bindgen cannot find the output binary.
Contributor
Author
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
* feat(droid): add downscale/upscale API for worker thread management Adds window.kbve.downscale() and window.kbve.upscale() to control droid worker thread usage at runtime. Downscale terminates canvas worker, mod workers, gateway pool, and overlay — keeping only DB + WS SharedWorkers for session persistence. Upscale restores full capacity. Designed for pages that need pthread/WASM thread headroom (e.g. isometric game). * test(droid-e2e): add scale management e2e tests for downscale/upscale 13 new Playwright tests covering: initial full mode, downscale to minimal, overlay/canvas teardown, DB+WS persistence, event emission, idempotency, upscale restoration, and full cycle error-free operation.
| @@ -0,0 +1,167 @@ | |||
| import { useEffect, useState, useCallback } from 'react'; | |||
| import { droid, workerURLs, getScaleLevel } from '@kbve/droid'; | |||
Check notice
Code scanning / CodeQL
Unused variable, import, function or class Note
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI 2 days ago
In general, unused imports should be removed to keep the codebase clean and avoid confusion. Since only getScaleLevel is unused in this file, we should remove it from the import list while keeping droid and workerURLs intact.
Concretely, in packages/npm/droid-e2e/src/app/ScaleTest.tsx, edit the import on line 2 to remove getScaleLevel from the destructuring import. No other code changes or additional imports are needed, because nothing in the file references getScaleLevel.
Suggested changeset
1
packages/npm/droid-e2e/src/app/ScaleTest.tsx
| @@ -1,5 +1,5 @@ | ||
| import { useEffect, useState, useCallback } from 'react'; | ||
| import { droid, workerURLs, getScaleLevel } from '@kbve/droid'; | ||
| import { droid, workerURLs } from '@kbve/droid'; | ||
| import type { DroidScaleLevel } from '@kbve/droid'; | ||
|
|
||
| export function ScaleTest() { |
Copilot is powered by AI and may make mistakes. Always verify output.
VRL requires guaranteed string type for replace(). Use string!() to assert type after the empty check, and replace!() for infallible call.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release: Dev → Main
9 atomic commits ready for main
Features
16fe596)8cf182f)Bug Fixes
624c0dd)3fd8aff)1b1ccda)83d2710)Chores
22495f6)0eb2d37)6d48bd8)This PR is automatically maintained by CI — KBVE Studio