Skip to content

fix(fudster): resolve all CodeQL alerts and improve package#8132

Merged
h0lybyte merged 1 commit intodevfrom
trunk/fix-fudster-codeql-1773705860
Mar 17, 2026
Merged

fix(fudster): resolve all CodeQL alerts and improve package#8132
h0lybyte merged 1 commit intodevfrom
trunk/fix-fudster-codeql-1773705860

Conversation

@h0lybyte
Copy link
Member

Summary

  • Replace 7 bare except: pass blocks with _logger.debug() messages for optional dependency imports (CodeQL py/empty-except Preparing Release #51-57)
  • Fix 3 mixed-return paths by adding explicit return statements or raising exceptions (CodeQL py/mixed-returns Preparing Release #44-46)
  • Add async context manager (__aenter__/__aexit__) to APIConnector to prevent session leaks
  • Fix raise eraise anti-pattern in DiscordClient to preserve tracebacks

Test plan

  • All 15 fudster unit tests pass (including new test_api_connector_context_manager)
  • flake8 lint passes with --max-line-length 120
  • Verify CodeQL alerts resolve after merge

Replace bare except-pass blocks with debug logging for optional
dependency imports, fix mixed-return paths in APIConnector,
ChromeClient, and DiscordClient, add async context manager support
to APIConnector, and fix raise-from-variable anti-pattern.
@github-actions
Copy link
Contributor

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

@h0lybyte h0lybyte merged commit 2a71639 into dev Mar 17, 2026
5 checks passed
@h0lybyte h0lybyte deleted the trunk/fix-fudster-codeql-1773705860 branch March 17, 2026 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant