fix(axum-kbve): add bevy_npc to Docker build pipeline#8133
Merged
Conversation
bevy_kbve_net now depends on bevy_npc via the npcdb feature flag. Without this change the Docker build fails because the bevy_npc crate path is missing from the container context.
…se trigger paths Without these paths, changes to bevy_kbve_net or bevy_npc would not trigger a rebuild of the kbve-build-base Docker image.
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bevy_npccrate toDockerfile,Dockerfile.base, andCargo.workspace.tomlso the Docker build resolvesbevy_kbve_net'snpcdbfeature dependencybevy_kbve_netandbevy_npcpath triggers tokbve_basein CI file alterations workflow so base image rebuilds when either crate changesTest plan
bevy_kbve_net[npcdb]feature enabledbevy_npc/src/**changes