fix(npcdb): align proto enum indices and add missing personality variants#8138
Merged
fix(npcdb): align proto enum indices and add missing personality variants#8138
Conversation
…ants Set skipUnspecified: false on all npcdb codegen enums so generated array indices match proto integer values (fixes off-by-one for Personality, Element, CreatureFamily, MovementType, DifficultyMode, EquipSlot). Regenerate all four schema files via gen-all.mjs. Add Cheerful, Mysterious, Cowardly, Noble personality variants to bevy_battle::Personality, discordsh session types, proto_bridge, battle_bridge, and all 13 flavor text match blocks in content.rs. Extend proto_personality test to cover proto values 1-11. Regenerate npcdb.json with corrected integer enum values.
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
skipUnspecified: falseon all npcdb codegen enums so generated Zod array indices match proto integer values — fixes off-by-one mapping bug affectingPersonality,Element,CreatureFamily,MovementType,DifficultyMode, andEquipSlotPersonalityvariants (Cheerful,Mysterious,Cowardly,Noble) to all Rust consumers:bevy_battle, discordsh session types,proto_bridge,battle_bridge, and all 13 flavor text match blocks incontent.rsnpcdb,itemdb,mapdb,questdb) viagen-all.mjsnpcdb.jsonwith corrected integer enum valuesTest plan
cargo check -p axum-discordshpassesproto_personalitytest extended to cover proto values 1-11