refactor(docker): consolidate dual Dockerfile into single BuildKit-cached build#8216
Merged
refactor(docker): consolidate dual Dockerfile into single BuildKit-cached build#8216
Conversation
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
…ched build Remove Dockerfile.base and BUILD_BASE arg pattern across all apps (axum-kbve, discordsh, cryptothrone, mc). Single Dockerfile with cargo-chef + BuildKit cache mounts handles everything. On arc-runner, local cache backed by persistent PVC replaces the GHCR base image warm-up step, eliminating the build_base CI job entirely.
cc17439 to
862bde2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Dockerfile.baseandBUILD_BASEarg pattern across all apps (axum-kbve, discordsh, cryptothrone, mc)--mount=type=cachehandles dependency caching inline/home/runner/_cache/docker/) for persistent layer caching across pod restartsbuild_baseCI job,has_base/base_imageconfig outputs,basex/baseNx targets, and_basefile alteration filtersChanges
ARG BUILD_BASEremoved,FROM ${BUILD_BASE}→FROM foundationbasex/basetargets removed,BUILD_BASEbuild-args stripped, axum-kbve CI usestype=localcachebuild_basejob removed,has_base/base_imageconfig dropped_basefilter outputs removedTest plan
nx container axum-kbvebuilds locally (inline foundation stages)build_basejob