fix(mc): clone pumpkin source in Docker build after submodule removal#8217
Merged
fix(mc): clone pumpkin source in Docker build after submodule removal#8217
Conversation
Replace COPY from apps/mc/pumpkin/ submodule path with a pumpkin-source stage that git clones KBVE/Pumpkin at a pinned commit. Inline cargo-chef stages replace the deleted mc-rust-base image. Fixes CI failure from submodule removal in #8215.
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
COPY ./apps/mc/pumpkin/...(broken after submodule removal in chore(repo): remove pumpkin and postgres git submodules #8215) with apumpkin-sourcestage thatgit clonesKBVE/Pumpkinat pinned commite749ef61ARG BASE_IMAGE=ghcr.io/kbve/mc-rust-base:latest— inline cargo-chef stages handle dependency caching via BuildKit--mount=type=cacheDockerfileandDockerfile.devChanges
pumpkin-sourcestage:alpine/git→ shallow clone atPUMPKIN_REF(configurable via build-arg)rust-base→planner→deps: cargo-chef pattern caches compiled dependencies across buildsbuilder/plugin-builder:COPY --from=pumpkin-sourcereplacesCOPY ./apps/mc/pumpkin/Test plan
nx container mcbuilds locally