fix(isometric): use credentialless COEP to unblock local WebSocket#8218
Merged
fix(isometric): use credentialless COEP to unblock local WebSocket#8218
Conversation
The dev server's require-corp COEP policy blocked the WebSocket connection to the Lightyear game server on a different port. Switching to credentialless matches production and still enables crossOriginIsolated for SharedArrayBuffer/WASM threads.
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cross-Origin-Embedder-Policyfromrequire-corptocredentiallessin the Vite dev server configrequire-corpblocked WebSocket connections to the Lightyear game server (ws://127.0.0.1:5000) from the dev page (http://localhost:1420) because the game server doesn't send CORP headerscredentiallessstill enablescrossOriginIsolated(SharedArrayBuffer / WASM threads) while allowing cross-origin requests — matches the production Axum middlewareTest plan
isometric:quickand verify the Vite dev server starts on port 1420self.crossOriginIsolated === truein the browser console (SharedArrayBuffer still works)