fix(mc): fix /built-plugins missing dir and consolidate Dockerfiles#8224
Merged
fix(mc): fix /built-plugins missing dir and consolidate Dockerfiles#8224
Conversation
…rfiles Shell operator precedence caused mkdir to be skipped when cargo build failed, leaving /built-plugins missing for the final COPY stage. Closes #8220
…ockerfile Use ARG VARIANT=prod|dev to select entrypoint script at build time. Removes Dockerfile.dev and updates CI workflows + project.json to pass --build-arg VARIANT=dev where needed.
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mkdir -p /built-pluginsto be skipped when cargo build failed, makingCOPY --from=plugin-builder /built-plugins/fail with "not found". Movedmkdirto a separateRUNbefore the build so the directory always exists.DockerfileandDockerfile.devinto a singleDockerfilewithARG VARIANT=prod|devto select the entrypoint at build time. Updatedci-dev.yml,ci-mc-headless-e2e.yml, andproject.jsonto pass--build-arg VARIANT=dev.Changes
apps/mc/Dockerfile— unified Dockerfile with VARIANT build arg, fixed plugin build operator chainapps/mc/Dockerfile.dev— deleted.github/workflows/ci-dev.yml— useDockerfile+build-args: VARIANT=dev.github/workflows/ci-mc-headless-e2e.yml— sameapps/mc/project.json— sameTest plan
Dev Docker Build — MCjob passes (the failing job from [CI] CI - Dev / Dev Docker Build — MC — Failed #8220)MC Headless E2Ejob passes with the new build argdocker build --build-arg VARIANT=dev -t kbve-mc:dev .produces working image