fix(mc): switch Docker from Alpine/musl to Debian/glibc for plugin cdylib#8226
Merged
fix(mc): switch Docker from Alpine/musl to Debian/glibc for plugin cdylib#8226
Conversation
…lib support musl does not support cdylib crate types, so the plugin .so was never being compiled in Docker — the error was silently masked by || true. Switch rust-base to rust:1.94-slim-bookworm and final image to debian:bookworm-slim so cargo can produce the cdylib plugin. Closes #8220
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cdylibcrate type needed by the MC plugin.so. This was the real root cause behind [CI] CI - Dev / Dev Docker Build — MC — Failed #8220 — the|| truesilently masked the compile failure, leaving/built-pluginsempty.rust-basefromrust:1.94-alpine3.23torust:1.94-slim-bookworm(glibc)alpine:3.23todebian:bookworm-slim(needed to load the glibc-linked.so)Loaded kbve-mc-plugin (0.1.14))Changes
apps/mc/Dockerfile— Alpine → Debian for rust-base and final image, apt-get instead of apkTest plan
docker build --build-arg VARIANT=dev)Dev Docker Build — MCjob passesCloses #8220