feat(rows): unify proto definitions in packages/data/proto/rows/#9239
Merged
feat(rows): unify proto definitions in packages/data/proto/rows/#9239
Conversation
- Move rows.proto from apps/ows/rows/proto/ to packages/data/proto/rows/ (single source of truth alongside ows.proto) - Expand proto with full service definitions: PublicApi, InstanceManagement, CharacterPersistence, GlobalDataService, GameServerHealth - Add Iris messages: ZoneAssignment with seed + biome fields (procedural world support) - Add gRPC health check (grpc.health.v1 compatible) - Update build.rs to compile from central proto path - Vendored .rs files unchanged — regeneration in follow-up PR when grpc.rs is updated to match new message types
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Snapshot WarningsEnsure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice. Scanned FilesNone |
…ed .rs - Rewrite rows.proto to exactly match the existing grpc.rs service contract (PublicApi, InstanceManagement, CharacterPersistence, GlobalDataService, GameServerHealth) - Regenerate vendored src/proto/rows.rs from central proto - Add Iris messages (ZoneAssignment + seed/biome) as standalone messages with TODO stubs for gRPC service integration - Add SpinUpInstance.seed field for procedural world support - Add TODO stubs for: System gRPC service, Prometheus metrics, multi-cluster routing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rows.protofromapps/ows/rows/proto/topackages/data/proto/rows/(central location alongsideows.proto)seed+biomefields for procedural world supportbuild.rsto compile from central proto pathNotes
.rsfiles unchanged —grpc.rsrefactor to match new message types is a follow-up PRBUILD_PROTO=1 cargo build -p rowsto regenerate after grpc.rs update