Conversation
* fix(dashboard): remove empty body from KubeVirt VM start/stop/restart
The PUT to KubeVirt subresource endpoints was sending an empty JSON
body {} which triggered OpenAPI schema validation error: "The string
did not match the expected pattern". KubeVirt start/stop/restart
subresources expect no request body.
Also makes Content-Type header conditional — only set when a body
is present to avoid strict validators rejecting it.
* feat(dashboard): add KASM workspace backend + fix VM start error
Backend:
- Add KASM proxy routes (/dashboard/kasm/proxy, workspaces, scale)
- init_kasm_proxy() for reverse proxying to KASM web UI (port 6901)
- kasm_workspaces_handler lists deployments in kasm namespace via K8s API
- kasm_scale_handler scales workspace deployments (0 or 1 replicas)
- All endpoints require JWT + DASHBOARD_VIEW permission
Fix:
- Remove empty body {} from KubeVirt start/stop/restart PUT requests
(was triggering OpenAPI "string did not match expected pattern" error)
- Make Content-Type header conditional on body presence
chuckrpg-tls (chuckrpg.com) and chuckrpg-api-tls (api.chuckrpg.com) certificates existed in cluster but not in git, causing ArgoCD OutOfSync. Also adds chuckrpg-api-routes HTTPRoute for api.chuckrpg.com. All three ChuckRPG certs are now in git: - chuckrpg-tls (chuckrpg.com) - chuckrpg-api-tls (api.chuckrpg.com) - game-chuckrpg-tls (game.chuckrpg.com)
Contributor
Author
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Snapshot WarningsEnsure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice. OpenSSF Scorecard
Scanned Files
|
Backend: - Add Guacamole proxy routes (/dashboard/guac/proxy/*) for WebSocket tunnel to guacamole.angelscript.svc.cluster.local:8080 - init_guacamole_proxy() with session-based auth passthrough Frontend: - Add guacamole-common-js dependency (v1.5.0) - Create ReactVMGuacViewer component — Guacamole WebSocket tunnel client with toolbar (Ctrl+Alt+Del, keyboard toggle, fullscreen) - Add $guacTarget nanostore + openGuac/closeGuac to vmService - Add RDP button to VM cards alongside existing VNC button - Wire GuacViewer island into AstroVMDashboard
The npm @novnc/novnc package uses top-level await in CJS (browser.js) which breaks Rollup bundling. The previous fix externalized it, but then the dynamic import fails at runtime in production with: "Module name '@novnc/novnc/lib/rfb' does not resolve to a valid URL" Load the ESM build from esm.sh CDN instead, which avoids both the Rollup CJS parsing issue and the runtime module resolution failure.
…e limit (#9418) 5 github-runner triggers at 30s = 10 API calls/min = 600/hour. Increased all to 300s (5 min) = 1 call/min = 60/hour. VMs don't need 30-second response time — 5 minute polling is sufficient for CI job detection. This reduces GitHub API usage by 90% and prevents rate limit errors. Before: 600 API calls/hour → rate limit hit After: 60 API calls/hour → well within 5,000/hour limit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release: Dev → Main
6 atomic commits ready for main
Features
b65f1ea)732a752)Bug Fixes
621092f)d912627)40dd539)Chores
d8b02b4)This PR is automatically maintained by CI — KBVE Studio