Conversation
…ne entrypoint SCRIPT_PRESETS were passing shell commands as entrypoint (e.g. "uname -a && ..."), which the new validate_entrypoint() correctly rejects. Convert all presets to use absolute binary paths (/bin/sh, /usr/bin/python3, /usr/bin/node) as entrypoint and send the script body via env.CODE, which the VM init script reads from /dev/vdb.
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Snapshot WarningsEnsure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice. Scanned FilesNone |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SCRIPT_PRESETSinfirecrackerService.tswere passing shell commands (e.g.uname -a && cat /proc/cpuinfo) directly as theentrypointfieldvalidate_entrypoint()added in fix(firecracker-ctl): resolve memory leak, kill signal, validation, and scaling issues #9821 correctly rejects these — entrypoint must be an absolute binary path/bin/sh,/usr/bin/python3,/usr/bin/node) and send the script body viaenv.CODE/dev/vdband runsexec "$ENTRYPOINT" /tmp/code— no backend changes neededTest plan