Conversation
Two errors landed when #9937 (KASM iframe support) merged on top of a parallel refactor that split ServiceProxy::handle into handle + forward_request and added a new FIRECRACKER_NET proxy: 1. forward_request referenced raw_query, which was a local in the old handle() but never plumbed through the split. Restored the inline query extraction (req.uri().query()) since forward_request already has the request. 2. FIRECRACKER_NET ServiceProxy initializer was missing the new iframe_safe field. Set to false (matches every other non-KASM proxy).
Drop chisel-ubuntu-axum entirely. Use rust:1.83-alpine3.21 for the builder stages and alpine:3.21 for the runtime. The Rust binary now links against musl statically — no glibc dependency. The chiseled scratch image kept failing because Canonical's busybox slice ships only the bare binary with no applets, and there's no clean way to get sleep/cat/echo without pulling in 8+ coreutils sub-slices. Alpine ships all of this out of the box at ~5MB base.
Contributor
Author
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Snapshot WarningsEnsure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice. Scanned FilesNone |
github-actions
Bot
changed the title
PR #9950 added FabricProxy-Lite to the Dockerfile but didn't bump the version, so CI never built a new image. Fleet is still pulling 1.0.4 which doesn't have the mod, so Velocity's modern forwarding is rejected by the backend. Bumping to 1.0.5 triggers CI to build the new image with FabricProxy-Lite. Fleet will auto-update via deployment_yaml hook.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release: Dev → Main
2 atomic commits ready for main
Bug Fixes
a2eb732)Refactoring
a035ca3)This PR is automatically maintained by CI — KBVE Studio