feat: did lookup by weichweich · Pull Request #299 · KILTprotocol/kilt-node

weichweich · 2021-11-16T16:57:40Z

fixes KILTprotocol/ticket/issues/1698

rename DidAccount -> DidIdentifier

Checklist:

I have verified that the code works
- No panics! (checked arithmetic ops, no indexing array[3] use get(3), ...)
I have verified that the code is easy to understand
- If not, I have left a well-balanced amount of inline comments
This PR does not introduce new custom types
- If not, I have opened a companion PR with the type changes in the KILT types-definitions repository
I have left the code in a better state
I have documented the changes (where applicable)

ntn-x2

😇

weichweich · 2021-11-18T12:49:40Z

/bench runtime pallet pallet-did-lookup

kilt-command-bot · 2021-11-18T12:49:42Z

Benchmark Runtime Pallet for branch "aw-did-lookup" with command cargo run --quiet --release -p kilt-parachain --features=runtime-benchmarks -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet-did-lookup --extrinsic="*" --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=pallets/pallet-did-lookup/src/default_weights.rs --template=.maintain/weight-template.hbs

Results

Error: Io(Os { code: 2, kind: NotFound, message: "No such file or directory" })

ERROR: Unable to commit file pallets/pallet-did-lookup/src/default_weights.rs

Co-authored-by: Antonio <antonio@kilt.io>

weichweich · 2021-11-19T08:10:13Z

/bench runtime pallet did-lookup

kilt-command-bot · 2021-11-19T08:10:15Z

Benchmark Runtime Pallet for branch "aw-did-lookup" with command cargo run --quiet --release -p kilt-parachain --features=runtime-benchmarks -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=did-lookup --extrinsic="*" --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=pallets/did-lookup/src/default_weights.rs --template=.maintain/weight-template.hbs

Results

Error: Input("No benchmarks found which match your input.")

ERROR: Unable to commit file pallets/did-lookup/src/default_weights.rs

weichweich · 2021-11-19T09:29:33Z

/bench runtime pallet pallet-did-lookup

kilt-command-bot · 2021-11-19T09:29:35Z

Benchmark Runtime Pallet for branch "aw-did-lookup" with command cargo run --quiet --release -p kilt-parachain --features=runtime-benchmarks -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet-did-lookup --extrinsic="*" --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=pallets/pallet-did-lookup/src/default_weights.rs --template=.maintain/weight-template.hbs

Results

error: failed to load manifest for workspace member `/home/benchbot/bench-bot/git/mashnet-node/nodes/parachain`

Caused by:
  failed to load manifest for dependency `peregrine-runtime`

Caused by:
  failed to load manifest for dependency `pallet-did-lookup`

Caused by:
  failed to read `/home/benchbot/bench-bot/git/mashnet-node/pallets/did-lookup/Cargo.toml`

Caused by:
  No such file or directory (os error 2)

ERROR: Unable to commit file pallets/pallet-did-lookup/src/default_weights.rs

weichweich · 2021-11-19T09:31:37Z

/bench runtime pallet pallet-did-lookup

kilt-command-bot · 2021-11-19T09:31:39Z

Benchmark Runtime Pallet for branch "aw-did-lookup" with command cargo run --quiet --release -p kilt-parachain --features=runtime-benchmarks -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet-did-lookup --extrinsic="*" --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=pallets/pallet-did-lookup/src/default_weights.rs --template=.maintain/weight-template.hbs

Results

Pallet: "pallet_did_lookup", Extrinsic: "associate_account", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info
========
Storage: DidLookup ConnectedDids (r:1 w:1)

Median Slopes Analysis
========
-- Extrinsic Time --

Model:
Time ~=    74.37
              µs

Reads = 1
Writes = 1

Min Squares Analysis
========
-- Extrinsic Time --

Model:
Time ~=    74.37
              µs

Reads = 1
Writes = 1

Pallet: "pallet_did_lookup", Extrinsic: "associate_sender", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info
========
Storage: DidLookup ConnectedDids (r:1 w:1)

Median Slopes Analysis
========
-- Extrinsic Time --

Model:
Time ~=    17.57
              µs

Reads = 1
Writes = 1

Min Squares Analysis
========
-- Extrinsic Time --

Model:
Time ~=    17.57
              µs

Reads = 1
Writes = 1

Pallet: "pallet_did_lookup", Extrinsic: "remove_sender_association", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info
========
Storage: DidLookup ConnectedDids (r:1 w:1)

Median Slopes Analysis
========
-- Extrinsic Time --

Model:
Time ~=    18.99
              µs

Reads = 1
Writes = 1

Min Squares Analysis
========
-- Extrinsic Time --

Model:
Time ~=    18.99
              µs

Reads = 1
Writes = 1

Pallet: "pallet_did_lookup", Extrinsic: "remove_account_association", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info
========
Storage: DidLookup ConnectedDids (r:1 w:1)

Median Slopes Analysis
========
-- Extrinsic Time --

Model:
Time ~=    22.41
              µs

Reads = 1
Writes = 1

Min Squares Analysis
========
-- Extrinsic Time --

Model:
Time ~=    22.41
              µs

Reads = 1
Writes = 1

…hmarks -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet-did-lookup --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=pallets/pallet-did-lookup/src/default_weights.rs --template=.maintain/weight-template.hbs

weichweich · 2021-11-19T09:56:16Z

/bench runtime spiritnet-runtime pallet-did-lookup

kilt-command-bot · 2021-11-19T09:56:18Z

Benchmark Runtime Pallet for branch "aw-did-lookup" with command cargo run --quiet --release -p kilt-parachain --features=runtime-benchmarks -- benchmark --chain=spiritnet-dev --steps=50 --repeat=20 --pallet=pallet-did-lookup --extrinsic="*" --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./runtimes/spiritnet/src/weights/pallet_did-lookup.rs --template=.maintain/runtime-weight-template.hbs

Results

Pallet: "pallet_did_lookup", Extrinsic: "associate_account", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info
========
Storage: DidLookup ConnectedDids (r:1 w:1)

Median Slopes Analysis
========
-- Extrinsic Time --

Model:
Time ~=    75.15
              µs

Reads = 1
Writes = 1

Min Squares Analysis
========
-- Extrinsic Time --

Model:
Time ~=    75.15
              µs

Reads = 1
Writes = 1

Pallet: "pallet_did_lookup", Extrinsic: "associate_sender", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info
========
Storage: DidLookup ConnectedDids (r:1 w:1)

Median Slopes Analysis
========
-- Extrinsic Time --

Model:
Time ~=       18
              µs

Reads = 1
Writes = 1

Min Squares Analysis
========
-- Extrinsic Time --

Model:
Time ~=       18
              µs

Reads = 1
Writes = 1

Pallet: "pallet_did_lookup", Extrinsic: "remove_sender_association", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info
========
Storage: DidLookup ConnectedDids (r:1 w:1)

Median Slopes Analysis
========
-- Extrinsic Time --

Model:
Time ~=    18.92
              µs

Reads = 1
Writes = 1

Min Squares Analysis
========
-- Extrinsic Time --

Model:
Time ~=    18.92
              µs

Reads = 1
Writes = 1

Pallet: "pallet_did_lookup", Extrinsic: "remove_account_association", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info
========
Storage: DidLookup ConnectedDids (r:1 w:1)

Median Slopes Analysis
========
-- Extrinsic Time --

Model:
Time ~=    22.14
              µs

Reads = 1
Writes = 1

Min Squares Analysis
========
-- Extrinsic Time --

Model:
Time ~=    22.14
              µs

Reads = 1
Writes = 1

…hmarks -- benchmark --chain=spiritnet-dev --steps=50 --repeat=20 --pallet=pallet-did-lookup --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./runtimes/spiritnet/src/weights/pallet_did-lookup.rs --template=.maintain/runtime-weight-template.hbs

weichweich · 2021-11-19T11:57:23Z

/bench runtime peregrine pallet-did-lookup

kilt-command-bot · 2021-11-19T11:57:26Z

Benchmark Runtime Substrate Pallet for branch "aw-did-lookup" with command cargo run --quiet --release -p kilt-parachain --features=runtime-benchmarks -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet-did-lookup --extrinsic="*" --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./runtimes/peregrine/src/weights/pallet_did-lookup.rs --template=.maintain/runtime-weight-template.hbs

Results

Pallet: "pallet_did_lookup", Extrinsic: "associate_account", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info
========
Storage: DidLookup ConnectedDids (r:1 w:1)

Median Slopes Analysis
========
-- Extrinsic Time --

Model:
Time ~=    74.81
              µs

Reads = 1
Writes = 1

Min Squares Analysis
========
-- Extrinsic Time --

Model:
Time ~=    74.81
              µs

Reads = 1
Writes = 1

Pallet: "pallet_did_lookup", Extrinsic: "associate_sender", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info
========
Storage: DidLookup ConnectedDids (r:1 w:1)

Median Slopes Analysis
========
-- Extrinsic Time --

Model:
Time ~=    17.76
              µs

Reads = 1
Writes = 1

Min Squares Analysis
========
-- Extrinsic Time --

Model:
Time ~=    17.76
              µs

Reads = 1
Writes = 1

Pallet: "pallet_did_lookup", Extrinsic: "remove_sender_association", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info
========
Storage: DidLookup ConnectedDids (r:1 w:1)

Median Slopes Analysis
========
-- Extrinsic Time --

Model:
Time ~=    19.12
              µs

Reads = 1
Writes = 1

Min Squares Analysis
========
-- Extrinsic Time --

Model:
Time ~=    19.12
              µs

Reads = 1
Writes = 1

Pallet: "pallet_did_lookup", Extrinsic: "remove_account_association", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info
========
Storage: DidLookup ConnectedDids (r:1 w:1)

Median Slopes Analysis
========
-- Extrinsic Time --

Model:
Time ~=    22.32
              µs

Reads = 1
Writes = 1

Min Squares Analysis
========
-- Extrinsic Time --

Model:
Time ~=    22.32
              µs

Reads = 1
Writes = 1

…hmarks -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet-did-lookup --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./runtimes/peregrine/src/weights/pallet_did-lookup.rs --template=.maintain/runtime-weight-template.hbs

ntn-x2

Some stuff is minor, there are also some discussion points especially regarding the validity of the signature in the associate_account function.

weichweich · 2021-11-25T09:49:12Z

/bench runtime spiritnet-runtime pallet_did_lookup

kilt-command-bot · 2021-11-25T09:49:14Z

Benchmark Runtime Pallet for branch "aw-did-lookup" with command cargo run --quiet --release -p kilt-parachain --features=runtime-benchmarks -- benchmark --chain=spiritnet-dev --steps=50 --repeat=20 --pallet=pallet_did_lookup --extrinsic="*" --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./runtimes/spiritnet/src/weights/pallet_did_lookup.rs --template=.maintain/runtime-weight-template.hbs

Results

error: failed to select a version for `pallet-did-lookup`.
    ... required by package `peregrine-runtime v1.2.0 (/home/benchbot/bench-bot/git/mashnet-node/runtimes/peregrine)`
    ... which is depended on by `kilt-parachain v1.2.0 (/home/benchbot/bench-bot/git/mashnet-node/nodes/parachain)`
versions that meet the requirements `=1.2.0` are: 1.2.0

the package `peregrine-runtime` depends on `pallet-did-lookup`, with features: `pallet-balances` but `pallet-did-lookup` does not have these features.


failed to select a version for `pallet-did-lookup` which could resolve this conflict

ERROR: Unable to commit file ./runtimes/spiritnet/src/weights/pallet_did_lookup.rs

weichweich · 2021-11-25T09:49:23Z

/bench runtime peregrine pallet_did_lookup

kilt-command-bot · 2021-11-25T09:49:24Z

Benchmark Runtime Substrate Pallet for branch "aw-did-lookup" with command cargo run --quiet --release -p kilt-parachain --features=runtime-benchmarks -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_did_lookup --extrinsic="*" --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./runtimes/peregrine/src/weights/pallet_did_lookup.rs --template=.maintain/runtime-weight-template.hbs

Results

error: failed to select a version for `pallet-did-lookup`.
    ... required by package `peregrine-runtime v1.2.0 (/home/benchbot/bench-bot/git/mashnet-node/runtimes/peregrine)`
    ... which is depended on by `kilt-parachain v1.2.0 (/home/benchbot/bench-bot/git/mashnet-node/nodes/parachain)`
versions that meet the requirements `=1.2.0` are: 1.2.0

the package `peregrine-runtime` depends on `pallet-did-lookup`, with features: `pallet-balances` but `pallet-did-lookup` does not have these features.


failed to select a version for `pallet-did-lookup` which could resolve this conflict

ERROR: Unable to commit file ./runtimes/peregrine/src/weights/pallet_did_lookup.rs

weichweich · 2021-11-25T10:04:18Z

/bench runtime spiritnet-runtime pallet_did_lookup

kilt-command-bot · 2021-11-25T10:04:24Z

Benchmark Runtime Pallet for branch "aw-did-lookup" with command cargo run --quiet --release -p kilt-parachain --features=runtime-benchmarks -- benchmark --chain=spiritnet-dev --steps=50 --repeat=20 --pallet=pallet_did_lookup --extrinsic="*" --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./runtimes/spiritnet/src/weights/pallet_did_lookup.rs --template=.maintain/runtime-weight-template.hbs

Results

Pallet: "pallet_did_lookup", Extrinsic: "associate_account", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info
========
Storage: System Account (r:1 w:1)
Storage: DidLookup ConnectedDids (r:1 w:1)

Median Slopes Analysis
========
-- Extrinsic Time --

Model:
Time ~=    100.1
              µs

Reads = 2
Writes = 2

Min Squares Analysis
========
-- Extrinsic Time --

Model:
Time ~=    100.1
              µs

Reads = 2
Writes = 2

Pallet: "pallet_did_lookup", Extrinsic: "associate_sender", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info
========
Storage: System Account (r:1 w:1)
Storage: DidLookup ConnectedDids (r:1 w:1)

Median Slopes Analysis
========
-- Extrinsic Time --

Model:
Time ~=    41.38
              µs

Reads = 2
Writes = 2

Min Squares Analysis
========
-- Extrinsic Time --

Model:
Time ~=    41.38
              µs

Reads = 2
Writes = 2

Pallet: "pallet_did_lookup", Extrinsic: "remove_sender_association", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info
========
Storage: DidLookup ConnectedDids (r:1 w:1)
Storage: System Account (r:1 w:1)

Median Slopes Analysis
========
-- Extrinsic Time --

Model:
Time ~=    38.91
              µs

Reads = 2
Writes = 2

Min Squares Analysis
========
-- Extrinsic Time --

Model:
Time ~=    38.91
              µs

Reads = 2
Writes = 2

Pallet: "pallet_did_lookup", Extrinsic: "remove_account_association", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info
========
Storage: DidLookup ConnectedDids (r:1 w:1)
Storage: System Account (r:1 w:1)

Median Slopes Analysis
========
-- Extrinsic Time --

Model:
Time ~=    42.38
              µs

Reads = 2
Writes = 2

Min Squares Analysis
========
-- Extrinsic Time --

Model:
Time ~=    42.38
              µs

Reads = 2
Writes = 2

weichweich · 2021-11-25T10:04:26Z

/bench runtime peregrine pallet_did_lookup

…hmarks -- benchmark --chain=spiritnet-dev --steps=50 --repeat=20 --pallet=pallet_did_lookup --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./runtimes/spiritnet/src/weights/pallet_did_lookup.rs --template=.maintain/runtime-weight-template.hbs

kilt-command-bot · 2021-11-25T10:14:08Z

Benchmark Runtime Substrate Pallet for branch "aw-did-lookup" with command cargo run --quiet --release -p kilt-parachain --features=runtime-benchmarks -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_did_lookup --extrinsic="*" --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./runtimes/peregrine/src/weights/pallet_did_lookup.rs --template=.maintain/runtime-weight-template.hbs

Results

Pallet: "pallet_did_lookup", Extrinsic: "associate_account", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info
========
Storage: System Account (r:1 w:1)
Storage: DidLookup ConnectedDids (r:1 w:1)

Median Slopes Analysis
========
-- Extrinsic Time --

Model:
Time ~=    100.7
              µs

Reads = 2
Writes = 2

Min Squares Analysis
========
-- Extrinsic Time --

Model:
Time ~=    100.7
              µs

Reads = 2
Writes = 2

Pallet: "pallet_did_lookup", Extrinsic: "associate_sender", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info
========
Storage: System Account (r:1 w:1)
Storage: DidLookup ConnectedDids (r:1 w:1)

Median Slopes Analysis
========
-- Extrinsic Time --

Model:
Time ~=    41.26
              µs

Reads = 2
Writes = 2

Min Squares Analysis
========
-- Extrinsic Time --

Model:
Time ~=    41.26
              µs

Reads = 2
Writes = 2

Pallet: "pallet_did_lookup", Extrinsic: "remove_sender_association", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info
========
Storage: DidLookup ConnectedDids (r:1 w:1)
Storage: System Account (r:1 w:1)

Median Slopes Analysis
========
-- Extrinsic Time --

Model:
Time ~=    39.03
              µs

Reads = 2
Writes = 2

Min Squares Analysis
========
-- Extrinsic Time --

Model:
Time ~=    39.03
              µs

Reads = 2
Writes = 2

Pallet: "pallet_did_lookup", Extrinsic: "remove_account_association", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info
========
Storage: DidLookup ConnectedDids (r:1 w:1)
Storage: System Account (r:1 w:1)

Median Slopes Analysis
========
-- Extrinsic Time --

Model:
Time ~=    42.01
              µs

Reads = 2
Writes = 2

Min Squares Analysis
========
-- Extrinsic Time --

Model:
Time ~=    42.01
              µs

Reads = 2
Writes = 2

…hmarks -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_did_lookup --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./runtimes/peregrine/src/weights/pallet_did_lookup.rs --template=.maintain/runtime-weight-template.hbs

ntn-x2

LGMT! 👏 Maybe we can clean up the origin type from all the pallets and the runtimes, as mentioned in the only outstanding comment, since this PR introduces the GenerateBenchmarkOrigin trait. Other than that, this could be merged!

weichweich · 2021-11-26T07:48:42Z

Maybe we can clean up the origin type from all the pallets and the runtimes

I would like to do that in a new PR since this would touch all the other pallets.

weichweich added 4 commits November 16, 2021 11:29

new did lookup pallet

0b0cf34

feat: add calls

6c10c8f

doc: add call doc

5271e11

tests: mock origin

5f71ecc

ntn-x2 reviewed Nov 17, 2021

View reviewed changes

Comment thread pallets/did-lookup/src/lib.rs Outdated

Comment thread pallets/did-lookup/src/lib.rs Outdated

weichweich added 3 commits November 17, 2021 11:04

test: test calls

a11c696

add did-lookup to runtimes and benchmark

bee32c6

fix tests & benchmarks

b28d590

weichweich and others added 2 commits November 18, 2021 17:50

clippy

29e9653

Apply suggestions from code review

400045d

Co-authored-by: Antonio <antonio@kilt.io>

same folder name as crate

06472da

fix dependencies

1926374

kiltbot and others added 4 commits November 19, 2021 12:59

configure weights

e51e024

remove todo

c5e1604

use DID origin

4c67235

weichweich requested a review from ntn-x2 November 23, 2021 09:29

ntn-x2 reviewed Nov 23, 2021

View reviewed changes

weichweich added 11 commits November 24, 2021 09:02

add GenerateBenchmarkOrigin doc

b70a73b

no migations no try-runtime

63b2b73

use associate type

e5e5474

out source connection record & docs

66f06ca

remove wrong weights

f9824d1

naming

f5816e8

more info

ad1e191

expiration

3ed6c61

specific error

16cca43

🧹🐢

d95d7c2

more doc

ebdf5a4

fix features

dd76db1

weichweich requested a review from ntn-x2 November 25, 2021 11:05

weichweich self-assigned this Nov 25, 2021

ntn-x2 approved these changes Nov 25, 2021

View reviewed changes

weichweich merged commit e61b091 into develop Nov 26, 2021

weichweich deleted the aw-did-lookup branch November 26, 2021 07:51

Conversation

weichweich commented Nov 16, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

fixes KILTprotocol/ticket/issues/1698

Checklist:

Uh oh!

ntn-x2 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

weichweich commented Nov 18, 2021

Uh oh!

kilt-command-bot Bot commented Nov 18, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

weichweich commented Nov 19, 2021

Uh oh!

kilt-command-bot Bot commented Nov 19, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

weichweich commented Nov 19, 2021

Uh oh!

kilt-command-bot Bot commented Nov 19, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

weichweich commented Nov 19, 2021

Uh oh!

kilt-command-bot Bot commented Nov 19, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

weichweich commented Nov 19, 2021

Uh oh!

kilt-command-bot Bot commented Nov 19, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

weichweich commented Nov 19, 2021

Uh oh!

kilt-command-bot Bot commented Nov 19, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ntn-x2 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

weichweich commented Nov 25, 2021

Uh oh!

kilt-command-bot Bot commented Nov 25, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

weichweich commented Nov 25, 2021

Uh oh!

kilt-command-bot Bot commented Nov 25, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

weichweich commented Nov 25, 2021

Uh oh!

kilt-command-bot Bot commented Nov 25, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

weichweich commented Nov 25, 2021

Uh oh!

kilt-command-bot Bot commented Nov 25, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ntn-x2 left a comment

Choose a reason for hiding this comment

Uh oh!

weichweich commented Nov 26, 2021

Uh oh!

Reviewers

weichweich commented Nov 16, 2021 •

edited

Loading

kilt-command-bot Bot commented Nov 18, 2021 •

edited

Loading

kilt-command-bot Bot commented Nov 19, 2021 •

edited

Loading

kilt-command-bot Bot commented Nov 19, 2021 •

edited

Loading

kilt-command-bot Bot commented Nov 19, 2021 •

edited

Loading

kilt-command-bot Bot commented Nov 19, 2021 •

edited

Loading

kilt-command-bot Bot commented Nov 19, 2021 •

edited

Loading

kilt-command-bot Bot commented Nov 25, 2021 •

edited

Loading

kilt-command-bot Bot commented Nov 25, 2021 •

edited

Loading

kilt-command-bot Bot commented Nov 25, 2021 •

edited

Loading

kilt-command-bot Bot commented Nov 25, 2021 •

edited

Loading