fix: no default accounts#306
Merged
weichweich merged 8 commits intodevelopfrom Dec 17, 2021
Merged
Conversation
wischli
reviewed
Dec 14, 2021
Contributor
wischli
left a comment
wischli
left a comment
There was a problem hiding this comment.
I would like to move the pallet ids to the constants and import them from there.
ntn-x2
approved these changes
Dec 16, 2021
Contributor
ntn-x2
left a comment
ntn-x2
left a comment
There was a problem hiding this comment.
LGMT! I did not check the crowdloan pallet as I guess we need to merge master back into develop and develop back into this branch.
| pub type SlowAdjustingFeeUpdate<R> = | ||
| TargetedFeeAdjustment<R, TargetBlockFullness, AdjustmentVariable, MinimumMultiplier>; | ||
|
|
||
| /// Unique identifiers for pallets. |
Contributor
There was a problem hiding this comment.
W: I would move the pallet_id module into its own file. I know it does not have a lot of information, but it is easier to find. This lib.rs file feels like a big pot of stuff.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes KILTProtocol/ticket#1715
This should not change anything. But just to make sure that these potentially problematic lines are not copied and used somewhere else, I would change it.
Checklist:
array[3]useget(3), ...)