-
Notifications
You must be signed in to change notification settings - Fork 255
Issue 2224 #2236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 2224 #2236
Conversation
Plus: simplify behavior of "change all" button, so it is not turned on or off.
|
Hi @klayoutmatthias, awesome! Thanks for adding that! I've noticed some issues. Issue 1: Icons not drawn properlySteps to reproduce:
Issue 2: layer selection does not get appliedSteps to reproduce:
Also, I encountered the issue at some point that the combo box selection was not applied, Made a video: |
|
Very good. Thanks for testing! Turns out there was some serious architectural rework needed (I told you it's not easy). I uploaded new commits. If you find the time, please give it some test. For me it works well now. Best regards, Matthias |
|
Danke für das Testen. Das sieht dann eher nach einem Problem mit der Speicherverwaltung aus. Das Icon neben den Objekten im Baum links ist aber immer in Ordnung. Korrekt?
On Dec 10, 2025 05:36, Martin Jan Köhler ***@***.***> wrote:
[https://avatars.githubusercontent.com/u/29398377?s=20&v=4]martinjankoehler left a comment (KLayout/klayout#2236)<#2236 (comment)>
Beim ersten Öffnen sind alle Icons kaputt, außer dem des effektiven Layers:
Bildschirmfoto.2025-12-10.um.05.33.18.jpg (view on web)<https://github.com/user-attachments/assets/b3c920db-990c-4c64-835a-724d412db9f8>
Wählt man was andres aus, oder öffnet den Dialog erneut wie vorher, dann sind die Icons wieder alle dahin:
Bildschirmfoto.2025-12-10.um.05.35.14.jpg (view on web)<https://github.com/user-attachments/assets/36b1a5f4-428b-46c5-a7f1-818af77c8c90>
—
Reply to this email directly, view it on GitHub<#2236 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AGEHQCJ4NV364UPFTCJZ3ST4A6PLVAVCNFSM6AAAAACNXMAHP2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTMMZVGM2DGMRTG4>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
|
@klayoutmatthias ja, links im Baum stimmen die Icons, auch bei ~500 Elementen in der Selektion |
|
I can't reproduce the problem when not using a technology. |
|
I just noticed we switched to German / Austrian :) I pushed a commit which I hope fixes the problem now. There was a place where the image for the icon wasn't copied by Qt. So basically the image is free'd memory. That would explain, why it can be reproduced occasionally only. Thanks for testing! :) Matthias |
|
Before I still had the issue (even rebuilt from scratch, which I retested after @stefanottili comment). |






No description provided.