Make compatible with V8 #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 small changes to make it compatible with Umbraco V8 In 8 tabs are not stored on the current editorState but on the variants property. So updated the code to get them from the active variant when there is a variants property on the editorState. jQuery load is deprecated in the version used in V8. So updated that as well. I did not test my changes on V7.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2 small changes to make it compatible with Umbraco V8
In 8 tabs are not stored on the current editorState but on the variants property. So updated the code to get them from the active variant when there is a variants property on the editorState.
jQuery load is deprecated in the version used in V8. So updated that as well.
I did not test my changes on V7.