perf: defer getpass import in console.py to Console.input()#6
Closed
perf: defer getpass import in console.py to Console.input()#6
Conversation
Move `from getpass import getpass` from module level to inside the `input()` method, only when password=True. The getpass module imports contextlib and termios which are unnecessary for normal Console usage.
Owner
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Move
from getpass import getpassfrom module level to insideConsole.input(), only whenpassword=True. Thegetpassmodule importscontextlibandtermioswhich are unnecessary for normal Console usage.Test updated to patch
getpass.getpassinstead of the module-level name.Testing
952 passed on CPython 3.9–3.14 and PyPy 3.10.