Prevent failed engines from re-activating.#170
Merged
jwvanderbeck merged 2 commits intoKSP-RO:devfrom Jun 6, 2017
Merged
Conversation
This commit suppresses the Activate/Deactivate Engine right-click command when an engine experiences a shutdown failure, and restores the GUI when the engine is repaired. Fixes KSP-RO#160.
Changes to IgnitionFail cannot be tested due to KSP-RO#163.
Starstrider42
commented
Jun 5, 2017
| @@ -148,6 +153,9 @@ public override float DoRepair() | |||
| EngineHandler engine = engines[i]; | |||
| { | |||
| engine.engine.Shutdown(); | |||
Contributor
Author
There was a problem hiding this comment.
@jwvanderbeck, do you remember what the logic was behind making an ignitor repair shut down the engine? This was added in commit 1781eae.
Collaborator
There was a problem hiding this comment.
As I recall it wasn't so much causing the engine to fail upon repair, but just shut it down in case it was already running. It is a bit hazy but I seem to recall a situation where you could ignite the engine, get a failure and then if you repaired the failure the engine would immediately jump back into the running state. So this was just to ensure that if it failed to ignite, and then you fixed it, you would have to re-ignite it using up an ignition.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit suppresses the Activate/Deactivate Engine right-click command when an engine experiences a shutdown failure, and restores the GUI when the engine is repaired. I don't understand why
ModuleEnginesrequires me to set the events'guiActivewhen other modules make do with justactive. Fixes #160.I have only tested this fix on stock KSP, not RO.