Modified GetInfo to suppress info about texture only changes. #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t affect function of part should be all that is presetent.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was annoyed with several parts that use B9PS for texture changes that end up cluttering the part info popup in the VAB. These do not have a functional impact on the part, and I find the information unhelpful.
Before: 14 Texture Subtypes for 3 models (one skin and 2 endcaps). This info alone takes the entire screen height of the Part Info side menu and I'm still not to the the 6 Subtype descriptions that actually matter for different resources.
After: only info for the variants that change resources are presented. The previous textures used to be between the Crew Report definition that you can see the tail of at the top of the screen and the Part Subtypes still listed.
The part switcher still works for textures once the part is placed in the VAB, but since the Part Info doesn't mention texture variants it isn't clear from the thumbnail view which parts have texture options. It will probably confuse a lot of people that aren't aware of all the features in their mods. I'm using it mainly because of Nertea's habit of defining the skin of a part with one part switcher and then two more for each of the end caps. It just adds a lot of clutter. It would probably be better to have a flag in the part module definition to suppress the info that a user could add with a patch, but this was the quickest for me to implement for my game. One bug I have seen is that if one of the variants is empty (no resources) version the subtype count includes this, but the no resource variant isn't listed in the Subtypes.
I'll leave it up to the maintainers to decide if it's worth making this change.