Fix deuterium FuelName in SystemHeatBoiloff patch#110
Merged
ChrisAdderley merged 1 commit intoKSPModStewards:devfrom Aug 14, 2024
Merged
Conversation
The patch that deletes module-level CoolingCost is meant to apply to Far Future Tech fusion tanks, which hold LqdDeuterium, not LqdHydrogen. The mistake didn't really hurt anything, since those tanks also hold LqdHe3 (so they get the patch anyway) and there aren't (and shouldn't be) any non-fusion cryo tanks with CoolingCost defined on the module itself (rather than in a BOILOFFCONFIG). Still, the patch ought to specify the correct matching criteria for the modules it intends to modify.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The patch that deletes module-level CoolingCost is meant to apply to Far Future Tech fusion tanks, which hold LqdDeuterium, not LqdHydrogen. The mistake didn't really hurt anything, since those tanks also hold LqdHe3 (so they get the patch anyway) and there aren't (and shouldn't be) any non-fusion cryo tanks with CoolingCost defined on the module itself (rather than in a BOILOFFCONFIG). Still, the patch ought to specify the correct matching criteria for the modules it intends to modify.