Update build system to use KSPBuildTools#144
Merged
Phantomical merged 2 commits intoKSPModStewards:masterfrom Apr 21, 2026
Merged
Update build system to use KSPBuildTools#144Phantomical merged 2 commits intoKSPModStewards:masterfrom
Phantomical merged 2 commits intoKSPModStewards:masterfrom
Conversation
JonnyOThan
reviewed
Apr 21, 2026
|
|
||
| <FileVersion>$(Version)</FileVersion> | ||
| <AssemblyVersion>1.0.0.0</AssemblyVersion> | ||
| <AssemblyInformationalVersion>$(Version)</AssemblyInformationalVersion> |
Contributor
Author
There was a problem hiding this comment.
I am unclear if changing the assembly version will cause issues. (it definitely will if any dependents are using KSPBurst, but I don't think that's an issue).
I'm inclined to leave this as-is for consistency with the old version.
Member
There was a problem hiding this comment.
Wasn't the old version 0.1.0.0?
Member
There was a problem hiding this comment.
BTW you can leave all this stuff in AssemblyInfo.cs, if nothing else for continuity sake. Just remove any lines that are generated from KSPBT
JonnyOThan
reviewed
Apr 21, 2026
JonnyOThan
reviewed
Apr 21, 2026
| GameData/SystemHeat/Parts/@thumbs | ||
|
|
||
| # KSPBuildTools / SDK-style build | ||
| /*.props.user |
Contributor
Author
There was a problem hiding this comment.
I'll make a follow-up PR to fix that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This converts the whole build system over to using KSPBuildTools. I haven't taken a look at CI yet, so I don't necessarily expect that to pass at the moment.
Some notes:
GameData/SystemHeat/Plugins, though they are gitignoredI have left the dll committed to the repo because I don't understand what CI is doing just yet. Once I have a better idea I will remove it.