[PR] 약속 - 약속 수정/삭제 리팩토링 #46
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
anjiniii
reviewed
Jan 20, 2024
Comment on lines
+327
to
+344
| // 약속 수정페이지 설정 | ||
| func setupEditPlanPage(_ viewController: MakePlanViewController) { | ||
| viewController.titleLabel.text = "약속 수정하기" | ||
|
|
||
| viewController.planNameTextField.text = planTitle.text | ||
| viewController.planStartDateField.text = sendDate[0].replacingOccurrences(of: "-", with: ". ") | ||
| viewController.planStartDateField.textColor = UIColor.textDisabled | ||
| viewController.calendarButton.isEnabled = false | ||
|
|
||
| viewController.cautionLabel.text = "약속 기간은 수정할 수 없습니다." | ||
| viewController.cautionLabel.textColor = UIColor.textDisabled | ||
| viewController.cautionImage.isHidden = true | ||
|
|
||
| viewController.planStartDateField.isUserInteractionEnabled = false | ||
| viewController.makeButton.setTitle("수정", for: .normal) | ||
| viewController.planId = planId | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
오오 이렇게 뺀 건 좋은 것 같아여!
그런데 어쩌다가 이렇게 nextVC에 설정해야할 내용이 많아진건가요..??
Contributor
Author
There was a problem hiding this comment.
오우 이건 원래 있던 설정들인데 따로 함수화하면 깔끔해 보일것같아서 함수화를 해놓은거랍니다~~
anjiniii
approved these changes
Jan 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type ⚙️
What is this PR? 📝
Related Issue Number
Changes
Other information 🔥