Skip to content

Try to fix #13 by wrapping dplyr::bind_cols()#14

Merged
mrustl merged 1 commit intodevfrom
fix-dplyr-update
Jun 19, 2020
Merged

Try to fix #13 by wrapping dplyr::bind_cols()#14
mrustl merged 1 commit intodevfrom
fix-dplyr-update

Conversation

@hsonne
Copy link
Copy Markdown
Member

@hsonne hsonne commented Jun 19, 2020

dplyr::bind_cols() returns a 0-row data frame if the data frame to be bound has no rows. The wrapper colbind() handles the case that the data frame to be bound has no rows by converting it to a one row data frame with all fields being NA.


This change is Reviewable

bind_cols() returns a 0-row data frame if the
data frame to be bound has no rows. The wrapper
colbind() handles the case that the data frame
to be bound has no rows by converting it to a
one row data frame with all fields being NA.
@hsonne hsonne requested a review from mrustl June 19, 2020 13:32
Copy link
Copy Markdown
Member

@mrustl mrustl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@mrustl mrustl merged commit f593fbf into dev Jun 19, 2020
@mrustl mrustl deleted the fix-dplyr-update branch June 19, 2020 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants