feat: 优化课程启动 tips 和镜像拉取取消#262
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
摘要 (Summary)
本 PR 优化课程启动提示和镜像拉取弹窗体验:小 tips 从顶栏移动到未连接终端态,拉取镜像弹窗支持滚动展示 tips、动画优化和关闭按钮。点击关闭按钮会取消当前启动/镜像拉取流程,并回到“终端未连接”页面。
主要变更 (Key Changes)
变更类型 (Type of Change)
测试情况 (Testing Performed)
pnpm run checkpnpm exec vitest run src/pages/learn/utils/container.test.ts src/components/business/terminal/ImagePullProgressOverlay.test.tsx src/pages/learn/components/LearnTerminalPanel.test.tsx src/pages/learn/tips.test.ts src/pages/learn/components/LearnTopBar.test.tsxpnpm exec eslint src/pages/Learn.tsx src/pages/learn/components/LearnTopBar.tsx src/pages/learn/components/LearnTopBar.test.tsx src/pages/learn/components/LearnTerminalPanel.tsx src/pages/learn/components/LearnTerminalPanel.test.tsx src/pages/learn/hooks/useLearnContainer.ts src/pages/learn/hooks/useContainerActions.ts src/pages/learn/hooks/useContainerRefs.ts src/pages/learn/utils/container.ts src/pages/learn/utils/container.test.ts src/pages/learn/tips.ts src/pages/learn/tips.test.ts src/components/business/Terminal.tsx src/components/business/SqlTerminal.tsx src/components/business/CodeTerminal.tsx src/components/business/terminal/ImagePullProgressOverlay.tsx src/components/business/terminal/ImagePullProgressOverlay.test.tsxgo test ./internal/api ./internal/dockergit diff --check给 Reviewer 的提示 (Notes for Reviewers)
重点关注关闭镜像拉取弹窗后的状态流转:前端应退回未连接终端态,后端拉取应随请求取消而停止,且旧启动请求晚返回时不应误连 Shell 终端。