Improve experimental data header/column parsing and make header dialog UI responsive#5
Merged
KWWyatt merged 2 commits intoMay 14, 2026
Conversation
Constrain header dialog child size hints so long labels and combo entries do not inflate minimum tracking size on Windows. Improve experimental header/column detection to ignore metadata comment lines while still accepting commented real headers like '# q I(q)'. Add regression coverage for metadata comment parsing and dialog size policies.
…h-in-experimentaldataheaderdialog-snudgo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
project.pyby adding_strip_comment_prefix,_is_comment_metadata_line, and_tokens_look_like_column_labelshelpers and updating_guess_experimental_header_rows,_read_experimental_column_names, and_first_data_tokensto skip or interpret comment/metadata lines correctly.# Background: ...) are not mistaken for column header lines and column label detection is improved (keywords matching and normalization).experimental_data_loader.pyUI: useQApplication.primaryScreen()to bound dialog size, set better defaults for resize and maximum size, enable word wrap for file and status labels, change preview wrapping and minimum height, and add_configure_column_comboto improveQComboBoxsizing behavior.test_experimental_data_header_dialog_geometry_is_screen_boundedandtest_experimental_data_metadata_comments_are_not_used_as_columns.Testing
pytest) including new UI and parser tests;test_experimental_data_header_dialog_geometry_is_screen_boundedpassed.test_experimental_data_metadata_comments_are_not_used_as_columnswhich verifies header detection andload_experimental_data_filebehavior and passed.test_experimental_data_header_dialog_allows_manual_column_selection) were executed and remained green.Codex Task