Ignore metadata comments in experimental data parsing and improve header dialog sizing#6
Merged
KWWyatt merged 2 commits intoMay 14, 2026
Conversation
When a commented line includes metadata and a trailing inline header fragment, extract the header-like segment instead of tokenizing metadata words as column labels. Add regression coverage for '# ... factor: 1.0 # q_(Å⁻¹) I(q)' style inputs.
…h-in-experimentaldataheaderdialog-x89ihv
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
_strip_comment_prefix,_is_comment_metadata_line, and_tokens_look_like_column_labels, and by updating_guess_experimental_header_rows,_read_experimental_column_names, and_first_data_tokensto use these helpers.ExperimentalDataHeaderDialogUI to size itself relative to the primary screen, set sensible minimums and maximums, enable word-wrapping for long file paths, change preview wrapping and minimum height, and configure columnQComboBoxsizing via a helper_configure_column_combo.Testing
test_experimental_data_metadata_comments_are_not_used_as_columns,test_experimental_data_ignores_metadata_prefix_before_inline_header, andtest_experimental_data_header_dialog_geometry_is_screen_boundedtotests/test_saxs_ui.pyand ran them withpytest; they passed.tests/test_saxs_ui.pyfile viapytest tests/test_saxs_ui.pyand the suite completed successfully.Codex Task