PhoneApp#1

Merged

KaBooMa merged 1 commit intoKaBooMa:bleeding-edgefrom

omar-akermi:bleeding-edge

Apr 20, 2025

Collaborator

omar-akermi commented Apr 19, 2025

✅ Introduced PhoneApp system to support custom in-game phone apps
🔄 Replaced BuildUI with OnCreated() for consistency with NPCs and Quests
🧠 Included PhoneAppManager for modular init flow
📖 Added README.md under S1API/PhoneApp/ for usage documentation

Tested under Mono + IL2CPP environments.


          PhoneApp

c46dcbb

omar-akermi changed the base branch from stable to bleeding-edge

April 19, 2025 23:10

Owner

KaBooMa commented Apr 20, 2025

@omar-akermi, this looks awesome! There's a few things I wanted to request. Nothing that I am going to stop the pull from though. Can you review the below and consider another PR based off them please?

Derive from the Registerable class. You can implement CreateInternal() for all your setup you do. DestroyInternal() for all clean up. Check our Quest.cs for example of how that flows.

Reasoning: Trying to keep all newly registered elements using the same flow. If this becomes cumbersome later, we can revisit. But I believe it'll be flexible enough for our needs.

Implement patches that utilize the ReflectionUtils to dynamically create and destroy the custom apps. See NPCPatches.cs and QuestPatches.cs for example :)

Just to remove the extra steps for a modder. Same principles applied for quests.

Do you think the UIFactory.cs would be better suited in a UI namespace? I'm think later when we want custom UI elements. That would give us a dedicated UI factory modders use for creating UI components regardless of phone app, HUD, menus, etc.

Appreciate you sharing bud!

KaBooMa merged commit 86d5fb1 into KaBooMa:bleeding-edge

Owner

KaBooMa commented Apr 20, 2025

🎉 This PR is included in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

KaBooMa added the released label

Collaborator Author

omar-akermi commented Apr 20, 2025

I'll be on all the changes you requested
otherwise for the third point
im not really certain if it would work properly (gotta test it first)

Owner

KaBooMa commented Apr 21, 2025

🎉 This PR is included in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

KaBooMa added the released on @publishing label

Owner

KaBooMa commented Apr 21, 2025

🎉 This PR is included in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

2 similar comments

Owner

KaBooMa commented Apr 21, 2025

🎉 This PR is included in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Owner

KaBooMa commented Apr 21, 2025

🎉 This PR is included in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Owner

KaBooMa commented Apr 22, 2025

🎉 This PR is included in version 1.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

MaxtorCoder pushed a commit that referenced this pull request


          Merge pull request #1 from KaBooMa/bleeding-edge

0050a8b

Bleeding edge

k073l pushed a commit to k073l/S1API that referenced this pull request


          Merge pull request KaBooMa#1 from ifBars/bleeding-edge

3a0f2dd

API working on game version 0.3.6f6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

released on @publishing released