Merged
Conversation
rosbo
approved these changes
Oct 29, 2018
Contributor
|
Thanks for adding tests :) |
|
May God bless you @chrisgorgo for sharing this solution for the bad X server connection 😄 |
wpbonelli
added a commit
to wpbonelli/flopy
that referenced
this pull request
May 9, 2023
wpbonelli
added a commit
to wpbonelli/flopy
that referenced
this pull request
May 9, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #359 by providing a workaround consisting of framebuffer X server that can be used to render visualizations offscreen on headless nodes. Example:
Ideally (from user convienience point of view) Xvfb should be started automatically via bash wrapper script set as an ENTRYPOINT, but that could lead to some unforseen side effects so I would suggest leaving this for another PR.