Conversation
sebbov
reviewed
Feb 26, 2019
Contributor
sebbov
left a comment
There was a problem hiding this comment.
General requests:
- Have you tested it end-to-end in Kaggle Kernels? For both CPU and GPU? Can you include the steps and results in the PR description please.
- Can you include a test under tests/ that exercises this and perhaps any existing Jupyter functionality this might affect?
- Please make sure our internal worker integration tests passes with the update to this image.
Contributor
|
+1 to all of Seb's questions |
Contributor
Author
|
Test output (including new test): |
Contributor
|
Did you answer the following general requests? Sorry if I missed them or they are still coming.
|
Contributor
Author
|
GPU Test output: |
Contributor
Author
Contributor
|
LGTM, thanks! |
rosbo
approved these changes
Feb 28, 2019
Contributor
|
Merge at will :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To use: