Conversation
ifigotin
reviewed
Mar 7, 2019
sebbov
reviewed
Mar 8, 2019
patches/kaggle_secrets.py
Outdated
| raise BackendError('Unexpected response from the service.') from e | ||
|
|
||
| def get_bigquery_access_token(self): | ||
| """ |
Contributor
There was a problem hiding this comment.
Nit: Summary line on this first line, then blank line, then more. E.g.:
"""Retrieves BigQuery access token information from the UserSecrets service.
This returns the token for the current kernel as well as its expiry (abs time) if it
is present.
Example:
...
Also provide type information (is the expiry a number of seconds since epoch? a datetime? ...) and explain what the returned expiry is when it is not present (None I suppose).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.