Prepare for release 1.8.0 #863
Conversation
stevemessick
force-pushed
the
release-prep
branch
from
24d7ad4 to
bac92de
Compare
rosbo
left a comment
rosbo
left a comment
There was a problem hiding this comment.
LGTM. Waiting for Erdal to confirm that KAGGLE_USERNAME is not necessary with the new token.
documentation/intro.md
Outdated
| `chmod 600 ~/.config/kaggle/kaggle.json` | ||
|
|
||
| You can also choose to export your Kaggle username and token to the environment: | ||
| You can export your Kaggle username and token to the environment: |
There was a problem hiding this comment.
@erdalsivri Correct me if I am wrong but I think you don't need to set the username with the new API token
documentation/intro.md
Outdated
| For example, if the file had the variable "proxy" you would export `KAGGLE_PROXY` | ||
| and it would be discovered by the client. | ||
|
|
||
| It is best to save the `export` commands to your shell init script so you don't have to re-run them for each new shell. Note that in some environments you need to log out and log back in for shell script updates to be fully propagated. |
There was a problem hiding this comment.
instead of suggesting to export in your bashrc (or equivalent), should we document how you can save it and load it the ~/.kaggle/access_token.
There was a problem hiding this comment.
Thanks! After rereading the auth code I simplified the docs to better match the implementation. PTAL.
docs/README.md
Outdated
| the `kaggle.json` in the format 'KAGGLE_<VARIABLE>' (note uppercase). | ||
| For example, if the file had the variable "proxy" you would export `KAGGLE_PROXY` | ||
| and it would be discovered by the client. | ||
| Note: If you already have a `~/.kaggle/kaggle.json` file it will continue to work. |
There was a problem hiding this comment.
nit: maybe rephrase to "If you already have a ~/.kaggle/kaggle.json file with legacy API credentials, it will continue to work".
Note, we use the term Legacy API Credentials on the settings page: https://screenshot.googleplex.com/74wnymz56e2fkNj
2 participants
No description provided.