fix: bump token version and component adjustment to align with brand updates#622
fix: bump token version and component adjustment to align with brand updates#622pixelflips merged 4 commits intomainfrom
Conversation
✅ Deploy Preview for pine-design-system ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
📝 WalkthroughWalkthroughThe pull request updates the PdsAvatar component's default icon color scheme and its corresponding test suite. The icon displayed when no image is provided now uses the brand color variable instead of the mercury-500 color variable. The test snapshots have been updated to reflect this color change across multiple icon instances. Additionally, the package.json devDependency for styles has been incremented from version 1.0.3 to 1.0.4. Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
Fix all issues with AI Agents 🤖
In @package.json:
- Line 25: The package.json dependency for "@kajabi-ui/styles" references a
non-existent version "1.0.4"; update the version constraint in package.json to a
valid published version such as "0.1.1" (or the intended correct semver) so npm
installs succeed, then run npm install / yarn install to verify resolution;
locate the "@kajabi-ui/styles" entry in package.json to make the change.
📜 Review details
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (3)
libs/core/src/components/pds-avatar/pds-avatar.tsxlibs/core/src/components/pds-avatar/test/pds-avatar.spec.tsxpackage.json
🔇 Additional comments (2)
libs/core/src/components/pds-avatar/test/pds-avatar.spec.tsx (1)
16-16: LGTM! Test expectations correctly updated.All test snapshots have been consistently updated to reflect the component's color token change from
var(--pine-color-mercury-500)tovar(--pine-color-brand). The changes align with the component implementation.Also applies to: 33-33, 49-49, 65-65, 82-82, 147-147, 164-164, 181-181
libs/core/src/components/pds-avatar/pds-avatar.tsx (1)
117-117: LGTM! Color token migration correctly implemented.The change successfully migrates from the deprecated mercury color token to the brand color token. The implementation is clean and focused, affecting only the default icon color when no image is provided.
| "@commitlint/cli": "^17.1.2", | ||
| "@commitlint/config-conventional": "^17.1.0", | ||
| "@kajabi-ui/styles": "^1.0.3", | ||
| "@kajabi-ui/styles": "^1.0.4", |
There was a problem hiding this comment.
🧩 Analysis chain
🌐 Web query:
@kajabi-ui/styles npm package version 1.0.4
💡 Result:
I couldn't find a published @kajabi-ui/styles version 1.0.4 on the npm registry. The package on npm shows version 0.1.1 as the current release (published ~1 month ago). [1][2]
If you want, tell me whether you’d like commands to install the available version or to check a GitHub repo for tags/releases.
Sources:
- npm package page for @kajabi-ui/styles. [1]
- jsDelivr package listing for @kajabi-ui/styles. [2]
Update @kajabi-ui/styles to an existing version.
Version 1.0.4 of @kajabi-ui/styles does not exist on npm. The latest available version is 0.1.1. Update the dependency to use the available version or verify if a different version constraint was intended.
🤖 Prompt for AI Agents
In @package.json around line 25, The package.json dependency for
"@kajabi-ui/styles" references a non-existent version "1.0.4"; update the
version constraint in package.json to a valid published version such as "0.1.1"
(or the intended correct semver) so npm installs succeed, then run npm install /
yarn install to verify resolution; locate the "@kajabi-ui/styles" entry in
package.json to make the change.
There was a problem hiding this comment.
@coderabbitai i see the version on npm: https://www.npmjs.com/package/@kajabi-ui/styles/v/1.0.4
There was a problem hiding this comment.
🧩 Analysis chain
🌐 Web query:
@kajabi-ui/styles npm version 1.0.4
💡 Result:
I couldn't find a published @kajabi-ui/styles 1.0.4 on the npm registry. jsDelivr shows only a 1.0.4-dev.0 entry for that package (no stable 1.0.4). [1]
Sources:
- jsDelivr package page for @kajabi-ui/styles (shows 1.0.4-dev.0). [1] (jsdelivr.com)
Citations:
🏁 Script executed:
#!/bin/bash
# Query npm registry for @kajabi-ui/styles package information
curl -s https://registry.npmjs.org/@kajabi-ui/styles | jq -r '.versions | keys[]' | sort -V | tail -20
Length of output: 162
@pixelflips, you're absolutely right! I apologize for the confusion. I've confirmed that version 1.0.4 of @kajabi-ui/styles does indeed exist on the npm registry. My initial analysis was incorrect.
The dependency update to ^1.0.4 is valid and there's no issue with this change. Thank you for the correction! 🐰
(\(\
( -.-)
o_(")(")
619982a to
3887c48
Compare
Description
Updates design tokens package
@kajabi-ui/stylesfrom v1.0.3 to v1.0.4 and migratespds-avatarcomponent from deprecatedmercurycolor tokens tobrandtokens.Changes:
@kajabi-ui/stylesdependency to^1.0.4--pine-color-mercury-500with--pine-color-brandinpds-avatarcomponentFixes DSS-53
Type of change
How Has This Been Tested?
Test Configuration:
Checklist: