Skip to content

fix: bump token version and component adjustment to align with brand updates#622

Merged
pixelflips merged 4 commits intomainfrom
fix/token-updates
Jan 5, 2026
Merged

fix: bump token version and component adjustment to align with brand updates#622
pixelflips merged 4 commits intomainfrom
fix/token-updates

Conversation

@pixelflips
Copy link
Member

Description

Updates design tokens package @kajabi-ui/styles from v1.0.3 to v1.0.4 and migrates pds-avatar component from deprecated mercury color tokens to brand tokens.

Changes:

  • Updated @kajabi-ui/styles dependency to ^1.0.4
  • Replaced --pine-color-mercury-500 with --pine-color-brand in pds-avatar component
  • Updated corresponding unit tests to reflect new color token

Fixes DSS-53

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • unit tests
  • e2e tests
  • accessibility tests
  • tested manually
  • other:

Test Configuration:

  • Pine versions: 3.12.0
  • OS: macOS
  • Browsers:
  • Screen readers:
  • Misc:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes
  • Design has QA'ed and approved this PR

@github-actions github-actions bot added bug Something isn't working package: core Changes have been made to the Core package labels Jan 5, 2026
@netlify
Copy link

netlify bot commented Jan 5, 2026

Deploy Preview for pine-design-system ready!

Name Link
🔨 Latest commit 3887c48
🔍 Latest deploy log https://app.netlify.com/projects/pine-design-system/deploys/695c3c551c1ad70008d2f081
😎 Deploy Preview https://deploy-preview-622--pine-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@pixelflips pixelflips self-assigned this Jan 5, 2026
@pixelflips pixelflips marked this pull request as ready for review January 5, 2026 19:39
@pixelflips
Copy link
Member Author

@coderabbitai review

@coderabbitai
Copy link

coderabbitai bot commented Jan 5, 2026

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@coderabbitai
Copy link

coderabbitai bot commented Jan 5, 2026

📝 Walkthrough

Walkthrough

The pull request updates the PdsAvatar component's default icon color scheme and its corresponding test suite. The icon displayed when no image is provided now uses the brand color variable instead of the mercury-500 color variable. The test snapshots have been updated to reflect this color change across multiple icon instances. Additionally, the package.json devDependency for styles has been incremented from version 1.0.3 to 1.0.4.

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main changes: bumping token version and adjusting the pds-avatar component to align with brand updates.
Description check ✅ Passed The description is comprehensive, following the template structure with all required sections filled: clear summary of changes, issue reference, type of change, testing details, and checklist completion.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
  • 📝 Generate docstrings

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Fix all issues with AI Agents 🤖
In @package.json:
- Line 25: The package.json dependency for "@kajabi-ui/styles" references a
non-existent version "1.0.4"; update the version constraint in package.json to a
valid published version such as "0.1.1" (or the intended correct semver) so npm
installs succeed, then run npm install / yarn install to verify resolution;
locate the "@kajabi-ui/styles" entry in package.json to make the change.
📜 Review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e7170a2 and 8012f99.

⛔ Files ignored due to path filters (1)
  • package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (3)
  • libs/core/src/components/pds-avatar/pds-avatar.tsx
  • libs/core/src/components/pds-avatar/test/pds-avatar.spec.tsx
  • package.json
🔇 Additional comments (2)
libs/core/src/components/pds-avatar/test/pds-avatar.spec.tsx (1)

16-16: LGTM! Test expectations correctly updated.

All test snapshots have been consistently updated to reflect the component's color token change from var(--pine-color-mercury-500) to var(--pine-color-brand). The changes align with the component implementation.

Also applies to: 33-33, 49-49, 65-65, 82-82, 147-147, 164-164, 181-181

libs/core/src/components/pds-avatar/pds-avatar.tsx (1)

117-117: LGTM! Color token migration correctly implemented.

The change successfully migrates from the deprecated mercury color token to the brand color token. The implementation is clean and focused, affecting only the default icon color when no image is provided.

"@commitlint/cli": "^17.1.2",
"@commitlint/config-conventional": "^17.1.0",
"@kajabi-ui/styles": "^1.0.3",
"@kajabi-ui/styles": "^1.0.4",
Copy link

@coderabbitai coderabbitai bot Jan 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

🧩 Analysis chain

🌐 Web query:

@kajabi-ui/styles npm package version 1.0.4

💡 Result:

I couldn't find a published @kajabi-ui/styles version 1.0.4 on the npm registry. The package on npm shows version 0.1.1 as the current release (published ~1 month ago). [1][2]

If you want, tell me whether you’d like commands to install the available version or to check a GitHub repo for tags/releases.

Sources:

  • npm package page for @kajabi-ui/styles. [1]
  • jsDelivr package listing for @kajabi-ui/styles. [2]

Update @kajabi-ui/styles to an existing version.

Version 1.0.4 of @kajabi-ui/styles does not exist on npm. The latest available version is 0.1.1. Update the dependency to use the available version or verify if a different version constraint was intended.

🤖 Prompt for AI Agents
In @package.json around line 25, The package.json dependency for
"@kajabi-ui/styles" references a non-existent version "1.0.4"; update the
version constraint in package.json to a valid published version such as "0.1.1"
(or the intended correct semver) so npm installs succeed, then run npm install /
yarn install to verify resolution; locate the "@kajabi-ui/styles" entry in
package.json to make the change.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧩 Analysis chain

🌐 Web query:

@kajabi-ui/styles npm version 1.0.4

💡 Result:

I couldn't find a published @kajabi-ui/styles 1.0.4 on the npm registry. jsDelivr shows only a 1.0.4-dev.0 entry for that package (no stable 1.0.4). [1]

Sources:

  1. jsDelivr package page for @kajabi-ui/styles (shows 1.0.4-dev.0). [1] (jsdelivr.com)

Citations:


🏁 Script executed:

#!/bin/bash
# Query npm registry for @kajabi-ui/styles package information
curl -s https://registry.npmjs.org/@kajabi-ui/styles | jq -r '.versions | keys[]' | sort -V | tail -20

Length of output: 162


@pixelflips, you're absolutely right! I apologize for the confusion. I've confirmed that version 1.0.4 of @kajabi-ui/styles does indeed exist on the npm registry. My initial analysis was incorrect.

The dependency update to ^1.0.4 is valid and there's no issue with this change. Thank you for the correction! 🐰

    (\(\
    ( -.-)
    o_(")(")

@pixelflips pixelflips merged commit 246ecf2 into main Jan 5, 2026
15 checks passed
@pixelflips pixelflips deleted the fix/token-updates branch January 5, 2026 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working package: core Changes have been made to the Core package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants