Skip to content

style(pds-copytext): move background color to span element#623

Merged
pixelflips merged 2 commits intomainfrom
style/copy-text-bg
Jan 5, 2026
Merged

style(pds-copytext): move background color to span element#623
pixelflips merged 2 commits intomainfrom
style/copy-text-bg

Conversation

@pixelflips
Copy link
Member

Description

Moves the background color style from the pds-button element to the inner span element in pds-copytext. This ensures the secondary background color is applied only to the text label rather than the entire button, providing correct visual styling for the component.

Fixes DSS-55

Screenshots

Before After
Screenshot 2026-01-05 at 12 12 04 PM Screenshot 2026-01-05 at 12 11 48 PM

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • tested manually

Test Configuration:

  • Pine versions: 3.12.0
  • OS: macOS
  • Browsers: Chrome
  • Screen readers: N/A
  • Misc: Visual inspection of pds-copytext component

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes
  • Design has QA'ed and approved this PR

@pixelflips pixelflips self-assigned this Jan 5, 2026
@netlify
Copy link

netlify bot commented Jan 5, 2026

Deploy Preview for pine-design-system ready!

Name Link
🔨 Latest commit 464075a
🔍 Latest deploy log https://app.netlify.com/projects/pine-design-system/deploys/695c1dbf4151f600085a32a9
😎 Deploy Preview https://deploy-preview-623--pine-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions github-actions bot added the package: core Changes have been made to the Core package label Jan 5, 2026
@pixelflips pixelflips marked this pull request as ready for review January 5, 2026 20:17
@pixelflips pixelflips merged commit a10649d into main Jan 5, 2026
15 checks passed
@pixelflips pixelflips deleted the style/copy-text-bg branch January 5, 2026 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

package: core Changes have been made to the Core package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants