fix: rollback typescript-eslint to v6 to resolve linting and spec errors#641
fix: rollback typescript-eslint to v6 to resolve linting and spec errors#641pixelflips merged 1 commit intomainfrom
Conversation
✅ Deploy Preview for pine-design-system ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Rolls back typescript-eslint from v8 to v6 and updates to compatible plugin versions to resolve linting and spec errors in CI. Changes: - @typescript-eslint/eslint-plugin: ^8.0.0 → 6.6.0 - @typescript-eslint/parser: ^8.0.0 → 6.6.0 (matched with eslint-plugin) - @stencil-community/eslint-plugin: ^0.10.0 → ^0.8.0 Version 0.8.0 of the stencil plugin properly supports typescript-eslint v6 (0.5.0 requires v5, 0.10.0 requires v7/v8). This provides proper peer dependency compatibility without --legacy-peer-deps while maintaining bug fixes from newer stencil plugin versions.
b4ec5ee to
998d3ed
Compare
|
@coderabbitai please review |
|
✅ Actions performedReview triggered.
|
📝 WalkthroughWalkthroughThis pull request modifies the 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
Description
Rolls back typescript-eslint packages from v8 to v6 with proper version compatibility to resolve linting and spec errors that appeared after the recent upgrade. The v8 upgrade introduced compatibility issues that caused CI failures in new PRs.
Changes:
@typescript-eslint/eslint-plugin:^8.0.0→6.6.0@typescript-eslint/parser:^8.0.0→6.6.0(matched with eslint-plugin for consistency)@stencil-community/eslint-plugin:^0.10.0→^0.8.0Why 0.8.0 for stencil plugin?
Version compatibility matrix:
0.5.0requires typescript-eslint^5.x(incompatible with v6)0.8.0requires typescript-eslint^5.x || ^6.x✅ (proper compatibility)0.10.0requires typescript-eslint^7.x || ^8.x(incompatible with v6)Using v0.8.0 provides:
Type of change
How Has This Been Tested?
Verified locally that linting and specs pass after rollback:
npm run lint.all- passes with no errors (only pre-existing warnings)@typescript-eslint/eslint-plugin: 6.6.0@typescript-eslint/parser: 6.6.0@stencil-community/eslint-plugin: 0.8.0Test Configuration:
Checklist: