Skip to content

style(pds-chip): update default chip padding#645

Merged
pixelflips merged 1 commit intomainfrom
style/chip-spacing-update
Jan 27, 2026
Merged

style(pds-chip): update default chip padding#645
pixelflips merged 1 commit intomainfrom
style/chip-spacing-update

Conversation

@pixelflips
Copy link
Member

@pixelflips pixelflips commented Jan 27, 2026

Description

Updates the default chip component horizontal padding from 12px to 8px to align with updated Figma designs.

Fixes UX-43

Screenshot 2026-01-26 at 4 17 32 PM

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • unit tests
  • e2e tests
  • accessibility tests
  • tested manually
  • other:

Test Configuration:

  • Pine versions: 3.14.1
  • OS: macOS
  • Browsers: Chrome
  • Screen readers:
  • Misc:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes
  • Design has QA'ed and approved this PR

@pixelflips pixelflips self-assigned this Jan 27, 2026
@netlify
Copy link

netlify bot commented Jan 27, 2026

Deploy Preview for pine-design-system ready!

Name Link
🔨 Latest commit e52f04d
🔍 Latest deploy log https://app.netlify.com/projects/pine-design-system/deploys/697808efb12233000833b40c
😎 Deploy Preview https://deploy-preview-645--pine-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions github-actions bot added the package: core Changes have been made to the Core package label Jan 27, 2026
@pixelflips pixelflips marked this pull request as ready for review January 27, 2026 00:38
@pixelflips
Copy link
Member Author

@amylu555 you can use the Deploy Preview in the netlify comment above to see the updates.

Copy link

@amylu555 amylu555 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks Phillip!

@pixelflips pixelflips merged commit 28dd364 into main Jan 27, 2026
15 checks passed
@pixelflips pixelflips deleted the style/chip-spacing-update branch January 27, 2026 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

package: core Changes have been made to the Core package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants